[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 07/10] vga-pci: Register "big-endian-framebuffer" as class propert
From: |
Eduardo Habkost |
Subject: |
[PULL 07/10] vga-pci: Register "big-endian-framebuffer" as class property |
Date: |
Wed, 14 Oct 2020 10:34:12 -0400 |
Class properties make QOM introspection simpler and easier, as
they don't require an object to be instantiated.
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20200921221045.699690-22-ehabkost@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
hw/display/vga-pci.c | 12 ++++--------
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/hw/display/vga-pci.c b/hw/display/vga-pci.c
index e5d9af5868..48d29630ab 100644
--- a/hw/display/vga-pci.c
+++ b/hw/display/vga-pci.c
@@ -267,13 +267,6 @@ static void pci_std_vga_realize(PCIDevice *dev, Error
**errp)
}
}
-static void pci_std_vga_init(Object *obj)
-{
- /* Expose framebuffer byteorder via QOM */
- object_property_add_bool(obj, "big-endian-framebuffer",
- vga_get_big_endian_fb, vga_set_big_endian_fb);
-}
-
static void pci_secondary_vga_realize(PCIDevice *dev, Error **errp)
{
PCIVGAState *d = PCI_VGA(dev);
@@ -386,6 +379,10 @@ static void vga_class_init(ObjectClass *klass, void *data)
k->class_id = PCI_CLASS_DISPLAY_VGA;
device_class_set_props(dc, vga_pci_properties);
dc->hotpluggable = false;
+
+ /* Expose framebuffer byteorder via QOM */
+ object_class_property_add_bool(klass, "big-endian-framebuffer",
+ vga_get_big_endian_fb,
vga_set_big_endian_fb);
}
static void secondary_class_init(ObjectClass *klass, void *data)
@@ -403,7 +400,6 @@ static void secondary_class_init(ObjectClass *klass, void
*data)
static const TypeInfo vga_info = {
.name = "VGA",
.parent = TYPE_PCI_VGA,
- .instance_init = pci_std_vga_init,
.class_init = vga_class_init,
};
--
2.28.0
- [PULL 00/10] machine + QOM queue, 2020-10-14, Eduardo Habkost, 2020/10/14
- [PULL 02/10] rng-random: register "filename" as class property, Eduardo Habkost, 2020/10/14
- [PULL 01/10] rng-egd: Register "chardev" as class property, Eduardo Habkost, 2020/10/14
- [PULL 04/10] input-linux: Register properties as class properties, Eduardo Habkost, 2020/10/14
- [PULL 05/10] input-barrier: Register properties as class properties, Eduardo Habkost, 2020/10/14
- [PULL 03/10] rng: Register "opened" as class property, Eduardo Habkost, 2020/10/14
- [PULL 06/10] i386: Register most CPU properties as class properties, Eduardo Habkost, 2020/10/14
- [PULL 07/10] vga-pci: Register "big-endian-framebuffer" as class property,
Eduardo Habkost <=
- [PULL 10/10] can-host-socketcan: Fix crash when 'if' option is not set, Eduardo Habkost, 2020/10/14
- [PULL 09/10] authz-list-file: Fix crash when filename is not set, Eduardo Habkost, 2020/10/14
- [PULL 08/10] vhost-user: Register "chardev" as class property, Eduardo Habkost, 2020/10/14
- Re: [PULL 00/10] machine + QOM queue, 2020-10-14, Peter Maydell, 2020/10/15