qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 0/6] Enable plugin support on msys2/mingw


From: Alex Bennée
Subject: Re: [PATCH v3 0/6] Enable plugin support on msys2/mingw
Date: Tue, 06 Oct 2020 12:35:19 +0100
User-agent: mu4e 1.5.5; emacs 28.0.50

Yonggang Luo <luoyonggang@gmail.com> writes:

> V2-V3
> Split following patches out
>
> V1-V2
> 1. Fixes review comments
> 2. Increase QEMU_PLUGIN_VERSION to 1 for compat  QEMU_PLUGIN_VERSION 0
> 3. Revise the loader to support for version 0 and 1
> 4. By export function qemu_plugin_initialize in plugin, and call it in loader=
> , so
>   we have no need call it in every plugin. And also provide a standard implem=
> entation,
>   anyway, use can also override it.
>
> Add this feature on msys2/mingw by using glib provided cross-platform dlsym f=
> unctional.

I've grabbed the first two fixes into plugins/next for now. Aside from
fixing the review comments I'd like to have an indication that the
proposed change to the API linking doesn't adversely affect the
performance of the plugins.

It might be worth enabling a --enable-plugins build for mingw gitlab as Cirrus
seems a bit broken at the moment.

Thanks,


-- 
Alex Bennée



reply via email to

[Prev in Thread] Current Thread [Next in Thread]