[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 06/36] qapi: Remove wildcard includes
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH v5 06/36] qapi: Remove wildcard includes |
|
Date: |
Tue, 6 Oct 2020 13:34:18 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 |
On 10/5/20 9:51 PM, John Snow wrote:
> Wildcard includes become hard to manage when refactoring and dealing
> with circular dependencies with strictly typed mypy.
>
> flake8 also flags each one as a warning, as it is not smart enough to
> know which names exist in the imported file.
>
> Remove them and include things explicitly by name instead.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
> Reviewed-by: Cleber Rosa <crosa@redhat.com>
> ---
> scripts/qapi/commands.py | 2 +-
> scripts/qapi/events.py | 7 ++++++-
> scripts/qapi/gen.py | 12 +++++++++---
> scripts/qapi/introspect.py | 7 ++++++-
> scripts/qapi/types.py | 8 +++++++-
> scripts/qapi/visit.py | 10 +++++++++-
> 6 files changed, 38 insertions(+), 8 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
- [PATCH v5 02/36] qapi: modify docstrings to be sphinx-compatible, (continued)
- [PATCH v5 02/36] qapi: modify docstrings to be sphinx-compatible, John Snow, 2020/10/05
- [PATCH v5 07/36] qapi: enforce import order/styling with isort, John Snow, 2020/10/05
- [PATCH v5 05/36] qapi: Prefer explicit relative imports, John Snow, 2020/10/05
- [PATCH v5 06/36] qapi: Remove wildcard includes, John Snow, 2020/10/05
- Re: [PATCH v5 06/36] qapi: Remove wildcard includes,
Philippe Mathieu-Daudé <=
- [PATCH v5 09/36] qapi: add pylintrc, John Snow, 2020/10/05
- [PATCH v5 08/36] qapi: delint using flake8, John Snow, 2020/10/05
- [PATCH v5 10/36] qapi/common.py: Remove python compatibility workaround, John Snow, 2020/10/05
- [PATCH v5 11/36] qapi/common.py: Add indent manager, John Snow, 2020/10/05