[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC v4 42/70] target/riscv: rvv-1.0: integer add-with-carry/subtrac
From: |
Richard Henderson |
Subject: |
Re: [RFC v4 42/70] target/riscv: rvv-1.0: integer add-with-carry/subtract-with-borrow |
Date: |
Sat, 29 Aug 2020 13:16:24 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 |
On 8/17/20 1:49 AM, frank.chang@sifive.com wrote:
> From: Frank Chang <frank.chang@sifive.com>
>
> Clear tail elements only if VTA is agnostic.
>
> Signed-off-by: Frank Chang <frank.chang@sifive.com>
> ---
> target/riscv/insn32.decode | 20 ++++++++++----------
> target/riscv/insn_trans/trans_rvv.inc.c | 2 +-
> target/riscv/vector_helper.c | 14 ++++----------
> 3 files changed, 15 insertions(+), 21 deletions(-)
The patch description is wrong, but the code is correct.
One nit:
> - uint8_t carry = vext_elem_mask(v0, i); \
> + uint8_t carry = !vm ? vext_elem_mask(v0, i) : 0; \
ETYPE carry = !vm && vext_elem_mask(v0, i);
r~
- [RFC v4 35/70] target/riscv: rvv-1.0: integer scalar move instructions, (continued)
- [RFC v4 35/70] target/riscv: rvv-1.0: integer scalar move instructions, frank . chang, 2020/08/17
- [RFC v4 36/70] target/riscv: rvv-1.0: floating-point move instruction, frank . chang, 2020/08/17
- [RFC v4 37/70] target/riscv: rvv-1.0: floating-point scalar move instructions, frank . chang, 2020/08/17
- [RFC v4 39/70] target/riscv: rvv-1.0: integer extension instructions, frank . chang, 2020/08/17
- [RFC v4 38/70] target/riscv: rvv-1.0: whole register move instructions, frank . chang, 2020/08/17
- [RFC v4 42/70] target/riscv: rvv-1.0: integer add-with-carry/subtract-with-borrow, frank . chang, 2020/08/17
- Re: [RFC v4 42/70] target/riscv: rvv-1.0: integer add-with-carry/subtract-with-borrow,
Richard Henderson <=
- [RFC v4 43/70] target/riscv: rvv-1.0: narrowing integer right shift instructions, frank . chang, 2020/08/17
- [RFC v4 40/70] target/riscv: rvv-1.0: single-width averaging add and subtract instructions, frank . chang, 2020/08/17
- [RFC v4 41/70] target/riscv: rvv-1.0: single-width bit shift instructions, frank . chang, 2020/08/17
- [RFC v4 44/70] target/riscv: rvv-1.0: widening integer multiply-add instructions, frank . chang, 2020/08/17
- [RFC v4 45/70] target/riscv: rvv-1.0: add Zvqmac extension, frank . chang, 2020/08/17
- [RFC v4 46/70] target/riscv: rvv-1.0: quad-widening integer multiply-add instructions, frank . chang, 2020/08/17