[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v2 07/10] vfio/platform: Remove dead assignment in vfio_intp_
From: |
Chenqun (kuhn) |
Subject: |
RE: [PATCH v2 07/10] vfio/platform: Remove dead assignment in vfio_intp_interrupt() |
Date: |
Wed, 26 Aug 2020 01:47:02 +0000 |
> > Clang static code analyzer show warning:
> > hw/vfio/platform.c:239:9: warning: Value stored to 'ret' is never read
> > ret = event_notifier_test_and_clear(intp->interrupt);
> > ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >
> > Reported-by: Euler Robot <euler.robot@huawei.com>
> > Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
> > Reviewed-by: Eric Auger <eric.auger@redhat.com>
> > ---
> > Cc: Alex Williamson <alex.williamson@redhat.com>
> > Cc: Eric Auger <eric.auger@redhat.com>
> > Cc: Stefan Hajnoczi <stefanha@redhat.com>
> > ---
> > hw/vfio/platform.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/hw/vfio/platform.c b/hw/vfio/platform.c index
> > ac2cefc9b1..869ed2c39d 100644
> > --- a/hw/vfio/platform.c
> > +++ b/hw/vfio/platform.c
> > @@ -236,7 +236,7 @@ static void vfio_intp_interrupt(VFIOINTp *intp)
> > trace_vfio_intp_interrupt_set_pending(intp->pin);
> > QSIMPLEQ_INSERT_TAIL(&vdev->pending_intp_queue,
> > intp, pqnext);
> > - ret = event_notifier_test_and_clear(intp->interrupt);
>
> Shouldn't we check the 'ret' like the other place in this function?
Hi, Li Qiang,
Eric、Alex、Stefan has already discussed this point in the V1 version.
https://patchwork.kernel.org/patch/11711897/
Thanks.
[PATCH v2 10/10] hw/display/vga:Remove redundant statement in vga_draw_graphic(), Chen Qun, 2020/08/25