[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 10/10] hw/display/vga:Remove redundant statement in vga_draw_g
From: |
Chen Qun |
Subject: |
[PATCH v2 10/10] hw/display/vga:Remove redundant statement in vga_draw_graphic() |
Date: |
Tue, 25 Aug 2020 19:24:47 +0800 |
Clang static code analyzer show warning:
hw/display/vga.c:1677:9: warning: Value stored to 'update' is never read
update = full_update;
^ ~~~~~~~~~~~
Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
---
Cc: Gerd Hoffmann <kraxel@redhat.com>
---
hw/display/vga.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/display/vga.c b/hw/display/vga.c
index 061fd9ab8f..836ad50c7b 100644
--- a/hw/display/vga.c
+++ b/hw/display/vga.c
@@ -1674,7 +1674,6 @@ static void vga_draw_graphic(VGACommonState *s, int
full_update)
if (!(s->cr[VGA_CRTC_MODE] & 2)) {
addr = (addr & ~0x8000) | ((y1 & 2) << 14);
}
- update = full_update;
page0 = addr & s->vbe_size_mask;
page1 = (addr + bwidth - 1) & s->vbe_size_mask;
if (full_update) {
--
2.23.0
- RE: [PATCH v2 07/10] vfio/platform: Remove dead assignment in vfio_intp_interrupt(), (continued)
[PATCH v2 08/10] usb/bus: Remove dead assignment in usb_get_fw_dev_path(), Chen Qun, 2020/08/25
[PATCH v2 09/10] hw/intc: Remove redundant statement in exynos4210_combiner_read(), Chen Qun, 2020/08/25
[PATCH v2 10/10] hw/display/vga:Remove redundant statement in vga_draw_graphic(),
Chen Qun <=