[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 5/5] meson: add NSIS building
From: |
Daniel P . Berrangé |
Subject: |
Re: [PATCH 5/5] meson: add NSIS building |
Date: |
Tue, 25 Aug 2020 17:07:48 +0100 |
User-agent: |
Mutt/1.14.6 (2020-07-11) |
On Tue, Aug 25, 2020 at 05:03:41PM +0100, Peter Maydell wrote:
> On Tue, 25 Aug 2020 at 16:14, Daniel P. Berrangé <berrange@redhat.com> wrote:
> > This is a verbose way of saying I think you should create a
> > nsis.py, not nsis.sh, to avoid the inherant portability problems of
> > shell that hit us over and over and over again.
>
> Does it have to be a separate script, or can we just write inline
> Python in the meson file? The main reason the current code is
> written in shell is because that's what you need to write it in
> so you can write it inline in a Makefile, and because half of
> it is "invoke this other command ($(SIGNCODE), makensis, etc)",
> which is what build systems are good at.
Meson just wants to have a command path + list of arguments.
So if you want to have the python code inline you can do that by passing
it as an arg by telling meson to run "python -e <codeblob>".
I think that's only sensible for one-liner scripts though. Otherwise it
is nicer to have a separate script that you can invoke directly for
testing / debugging purposes separately from meson.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [PATCH 0/5] meson: mingw installation fixes & nsis conversion, marcandre . lureau, 2020/08/25
- [PATCH 1/5] meson: pass confsuffix option, marcandre . lureau, 2020/08/25
- [PATCH 2/5] meson: use meson datadir instead of qemu_datadir, marcandre . lureau, 2020/08/25
- [PATCH 3/5] meson: add docdir option and pass pre-prefix qemu_docdir, marcandre . lureau, 2020/08/25
- [PATCH 4/5] meson: use meson mandir instead of qemu_mandir, marcandre . lureau, 2020/08/25
- [PATCH 5/5] meson: add NSIS building, marcandre . lureau, 2020/08/25
- Re: [PATCH 5/5] meson: add NSIS building, Peter Maydell, 2020/08/25
- Re: [PATCH 0/5] meson: mingw installation fixes & nsis conversion, Paolo Bonzini, 2020/08/25