qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 5/5] meson: add NSIS building


From: Peter Maydell
Subject: Re: [PATCH 5/5] meson: add NSIS building
Date: Tue, 25 Aug 2020 17:03:41 +0100

On Tue, 25 Aug 2020 at 16:14, Daniel P. Berrangé <berrange@redhat.com> wrote:
> This is a verbose way of saying I think you should create a
> nsis.py, not nsis.sh, to avoid the inherant portability problems of
> shell that hit us over and over and over again.

Does it have to be a separate script, or can we just write inline
Python in the meson file? The main reason the current code is
written in shell is because that's what you need to write it in
so you can write it inline in a Makefile, and because half of
it is "invoke this other command ($(SIGNCODE), makensis, etc)",
which is what build systems are good at.

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]