[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 09/58] sifive_u: Rename memmap enum constants
From: |
Daniel P . Berrangé |
Subject: |
Re: [PATCH v2 09/58] sifive_u: Rename memmap enum constants |
Date: |
Tue, 25 Aug 2020 12:10:28 +0100 |
User-agent: |
Mutt/1.14.6 (2020-07-11) |
On Wed, Aug 19, 2020 at 08:11:47PM -0400, Eduardo Habkost wrote:
> Some of the enum constant names conflict with the QOM type check
> macros (SIFIVE_U_OTP, SIFIVE_U_PRCI). This needs to be addressed
> to allow us to transform the QOM type check macros into functions
> generated by OBJECT_DECLARE_TYPE().
>
> Rename all the constants to SIFIVE_U_DEV_*, to avoid conflicts.
>
> Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
> Changes v1 -> v2:
> * Added more details to commit message
>
> ---
> Cc: Palmer Dabbelt <palmer@dabbelt.com>
> Cc: Alistair Francis <Alistair.Francis@wdc.com>
> Cc: Sagar Karandikar <sagark@eecs.berkeley.edu>
> Cc: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
> Cc: qemu-riscv@nongnu.org
> Cc: qemu-devel@nongnu.org
> ---
> include/hw/riscv/sifive_u.h | 30 ++++----
> hw/riscv/sifive_u.c | 136 ++++++++++++++++++------------------
> 2 files changed, 83 insertions(+), 83 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- Re: [PATCH v2 05/58] allwinner-h3: Rename memmap enum constants, (continued)
- [PATCH v2 06/58] aspeed_soc: Rename memmap/irqmap enum constants, Eduardo Habkost, 2020/08/19
- [PATCH v2 08/58] sifive_e: Rename memmap enum constants, Eduardo Habkost, 2020/08/19
- [PATCH v2 07/58] opentitan: Rename memmap enum constants, Eduardo Habkost, 2020/08/19
- [PATCH v2 09/58] sifive_u: Rename memmap enum constants, Eduardo Habkost, 2020/08/19
- Re: [PATCH v2 09/58] sifive_u: Rename memmap enum constants,
Daniel P . Berrangé <=
- [PATCH v2 10/58] aspeed_timer: Fix ASPEED_TIMER macro definition, Eduardo Habkost, 2020/08/19
- [PATCH v2 11/58] versatile: Fix typo in PCI_VPB_HOST definition, Eduardo Habkost, 2020/08/19
- [PATCH v2 12/58] virtio-ccw: Fix definition of VIRTIO_CCW_BUS_GET_CLASS, Eduardo Habkost, 2020/08/19
- [PATCH v2 13/58] hvf: Add missing include, Eduardo Habkost, 2020/08/19
- [PATCH v2 14/58] hcd-dwc2: Rename USB_*CLASS macros for consistency, Eduardo Habkost, 2020/08/19
- [PATCH v2 15/58] tulip: Move TulipState typedef to header, Eduardo Habkost, 2020/08/19
- [PATCH v2 16/58] throttle-groups: Move ThrottleGroup typedef to header, Eduardo Habkost, 2020/08/19
- [PATCH v2 17/58] pci: Move PCIBusClass typedef to pci.h, Eduardo Habkost, 2020/08/19