[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 05/58] allwinner-h3: Rename memmap enum constants
From: |
Daniel P . Berrangé |
Subject: |
Re: [PATCH v2 05/58] allwinner-h3: Rename memmap enum constants |
Date: |
Tue, 25 Aug 2020 12:07:02 +0100 |
User-agent: |
Mutt/1.14.6 (2020-07-11) |
On Wed, Aug 19, 2020 at 08:11:43PM -0400, Eduardo Habkost wrote:
> Some of the enum constant names conflict with the QOM type check
> macros (AW_H3_CCU, AW_H3_SYSCTRL). This needs to be addressed to
> allow us to transform the QOM type check macros into functions
> generated by OBJECT_DECLARE_TYPE().
>
> Rename all the constants to AW_H3_DEV_*, to avoid conflicts.
>
> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
> Changes v1 -> v2:
> * Added more details to commit message
>
> ---
> Cc: Beniamino Galvani <b.galvani@gmail.com>
> Cc: Peter Maydell <peter.maydell@linaro.org>
> Cc: Niek Linnenbank <nieklinnenbank@gmail.com>
> Cc: qemu-arm@nongnu.org
> Cc: qemu-devel@nongnu.org
> ---
> include/hw/arm/allwinner-h3.h | 62 ++++++++---------
> hw/arm/allwinner-h3.c | 124 +++++++++++++++++-----------------
> hw/arm/orangepi.c | 6 +-
> 3 files changed, 96 insertions(+), 96 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [PATCH v2 00/58] qom: Automated conversion of type checking boilerplate, Eduardo Habkost, 2020/08/19
- [PATCH v2 01/58] e1000: Rename QOM class cast macros, Eduardo Habkost, 2020/08/19
- [PATCH v2 04/58] pl110: Rename pl110_version enum values, Eduardo Habkost, 2020/08/19
- [PATCH v2 02/58] megasas: Rename QOM class cast macros, Eduardo Habkost, 2020/08/19
- [PATCH v2 03/58] vmw_pvscsi: Rename QOM class cast macros, Eduardo Habkost, 2020/08/19
- [PATCH v2 05/58] allwinner-h3: Rename memmap enum constants, Eduardo Habkost, 2020/08/19
- [PATCH v2 06/58] aspeed_soc: Rename memmap/irqmap enum constants, Eduardo Habkost, 2020/08/19
- [PATCH v2 08/58] sifive_e: Rename memmap enum constants, Eduardo Habkost, 2020/08/19
- [PATCH v2 07/58] opentitan: Rename memmap enum constants, Eduardo Habkost, 2020/08/19
- [PATCH v2 09/58] sifive_u: Rename memmap enum constants, Eduardo Habkost, 2020/08/19
- [PATCH v2 10/58] aspeed_timer: Fix ASPEED_TIMER macro definition, Eduardo Habkost, 2020/08/19