[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 03/12] semihosting: don't send the trailing '\0'
From: |
Alex Bennée |
Subject: |
[PATCH v2 03/12] semihosting: don't send the trailing '\0' |
Date: |
Wed, 22 Jul 2020 07:28:53 +0100 |
From: KONRAD Frederic <frederic.konrad@adacore.com>
Don't send the trailing 0 from the string.
Signed-off-by: KONRAD Frederic <frederic.konrad@adacore.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <1592215252-26742-2-git-send-email-frederic.konrad@adacore.com>
Message-Id: <20200717105139.25293-4-alex.bennee@linaro.org>
---
hw/semihosting/console.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/hw/semihosting/console.c b/hw/semihosting/console.c
index 22e7827824a..9b4fee92602 100644
--- a/hw/semihosting/console.c
+++ b/hw/semihosting/console.c
@@ -52,7 +52,9 @@ static GString *copy_user_string(CPUArchState *env,
target_ulong addr)
do {
if (cpu_memory_rw_debug(cpu, addr++, &c, 1, 0) == 0) {
- s = g_string_append_c(s, c);
+ if (c) {
+ s = g_string_append_c(s, c);
+ }
} else {
qemu_log_mask(LOG_GUEST_ERROR,
"%s: passed inaccessible address " TARGET_FMT_lx,
--
2.20.1
- [PATCH v2 00/12] candidate fixes for 5.1-rc1 (testing, semihosting, OOM tcg, x86 fpu), Alex Bennée, 2020/07/22
- [PATCH v2 01/12] shippable: add one more qemu to registry url, Alex Bennée, 2020/07/22
- [PATCH v2 02/12] semihosting: defer connect_chardevs a little more to use serialx, Alex Bennée, 2020/07/22
- [PATCH v2 04/12] util: add qemu_get_host_physmem utility function, Alex Bennée, 2020/07/22
- [PATCH v2 03/12] semihosting: don't send the trailing '\0',
Alex Bennée <=
- [PATCH v2 06/12] accel/tcg: better handle memory constrained systems, Alex Bennée, 2020/07/22
- Re: [PATCH v2 06/12] accel/tcg: better handle memory constrained systems, Richard Henderson, 2020/07/22
- Re: [PATCH v2 06/12] accel/tcg: better handle memory constrained systems, Alex Bennée, 2020/07/22
- Re: [PATCH v2 06/12] accel/tcg: better handle memory constrained systems, Daniel P . Berrangé, 2020/07/22
- Re: [PATCH v2 06/12] accel/tcg: better handle memory constrained systems, Richard Henderson, 2020/07/22
- Re: [PATCH v2 06/12] accel/tcg: better handle memory constrained systems, Daniel P . Berrangé, 2020/07/23
- Re: [PATCH v2 06/12] accel/tcg: better handle memory constrained systems, Alex Bennée, 2020/07/23
- Re: [PATCH v2 06/12] accel/tcg: better handle memory constrained systems, Daniel P . Berrangé, 2020/07/23
- Re: [PATCH v2 06/12] accel/tcg: better handle memory constrained systems, Alex Bennée, 2020/07/23
[PATCH v2 05/12] util/oslib-win32: add qemu_get_host_physmem implementation, Alex Bennée, 2020/07/22