[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PULL 28/53] Makefile: simplify MINIKCONF rules
From: |
Peter Maydell |
Subject: |
Re: [PULL 28/53] Makefile: simplify MINIKCONF rules |
Date: |
Fri, 17 Jul 2020 14:01:00 +0100 |
On Fri, 17 Jul 2020 at 12:20, Paolo Bonzini <pbonzini@redhat.com> wrote:
> Il ven 17 lug 2020, 13:03 Peter Maydell <peter.maydell@linaro.org> ha scritto:
>> There doesn't seem to be any machinery for creating .d
>> files for make to include to tell it that Kconfig has a
>> dependency on hw/Kconfig which has a dependency on hw/i2c/Kconfig etc.
>> How is this intended to work ?
>
>
> I cannot look at a build tree right now, but shouldn't that be in the .d file
> produced by minikconf.py Those are passed to minikconf.py as the second
> argument and included with "include $(SUBDIR_DEVICES_MAK_DEP)".
When you do a "make clean" those .d files get deleted
(but the config-devices.mak files do not). There is no rule
for rebuilding a config-devices.mak.d:
$ make -C build/x86 -n arm-softmmu/config-devices.mak.d
make: Entering directory '/home/petmay01/linaro/qemu-from-laptop/qemu/build/x86'
make[1]: Entering directory '/home/petmay01/linaro/qemu-from-laptop/qemu/slirp'
make[1]: Nothing to be done for 'all'.
make[1]: Leaving directory '/home/petmay01/linaro/qemu-from-laptop/qemu/slirp'
make: *** No rule to make target 'arm-softmmu/config-devices.mak.d'. Stop.
make: Leaving directory '/home/petmay01/linaro/qemu-from-laptop/qemu/build/x86'
and we include them with "-include", so Make silently
proceeds without the dependency information.
My guess is that we need to tell make that this rule:
$(SUBDIR_DEVICES_MAK): %/config-devices.mak: default-configs/%.mak
$(SRC_PATH)/Kconfig $(BUILD_DIR)/config-host.mak
also produces the .mak.d file somehow.
thanks
-- PMM
- [PULL 41/53] softmmu: move softmmu only files from root, (continued)
- [PULL 41/53] softmmu: move softmmu only files from root, Paolo Bonzini, 2020/07/06
- [PULL 27/53] accel/tcg: Add stub for probe_access(), Paolo Bonzini, 2020/07/06
- [PULL 49/53] target/i386/kvm: Simplify kvm_get_mce_cap_supported(), Paolo Bonzini, 2020/07/06
- [PULL 53/53] scripts: improve message when TAP based tests fail, Paolo Bonzini, 2020/07/06
- [PULL 46/53] accel/kvm: Simplify kvm_check_extension(), Paolo Bonzini, 2020/07/06
- [PULL 47/53] accel/kvm: Simplify kvm_check_extension_list(), Paolo Bonzini, 2020/07/06
- [PULL 45/53] accel/kvm: Let kvm_check_extension use global KVM state, Paolo Bonzini, 2020/07/06
- [PULL 28/53] Makefile: simplify MINIKCONF rules, Paolo Bonzini, 2020/07/06
[PULL 36/53] chardev/tcp: fix error message double free error, Paolo Bonzini, 2020/07/06
[PULL 48/53] target/i386/kvm: Simplify get_para_features(), Paolo Bonzini, 2020/07/06
[PULL 44/53] softmmu/vl: Remove the check for colons in -accel parameters, Paolo Bonzini, 2020/07/06
[PULL 52/53] target/i386: Enable TSX Suspend Load Address Tracking feature, Paolo Bonzini, 2020/07/06
[PULL 51/53] target/i386: Add SERIALIZE cpu feature, Paolo Bonzini, 2020/07/06
[PULL 34/53] iscsi: handle check condition status in retry loop, Paolo Bonzini, 2020/07/06
[PULL 50/53] target/i386/kvm: Simplify kvm_get_supported_[feature]_msrs(), Paolo Bonzini, 2020/07/06
[PULL 42/53] cpu-throttle: new module, extracted from cpus.c, Paolo Bonzini, 2020/07/06
[PULL 43/53] cpu-timers, icount: new modules, Paolo Bonzini, 2020/07/06