[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 09/12] tests/acceptance: Don't test reboot on cubieboard
From: |
Cleber Rosa |
Subject: |
Re: [PATCH v5 09/12] tests/acceptance: Don't test reboot on cubieboard |
Date: |
Mon, 13 Jul 2020 23:41:22 -0400 |
On Fri, Jul 10, 2020 at 01:06:46AM -0400, John Snow wrote:
> cubieboard does not have a functioning reboot, it halts and QEMU does
> not exit.
>
> vm.shutdown() is modified in a forthcoming patch that makes it less tolerant
> of race conditions on shutdown; tests should consciously decide to WAIT
> or to SHUTDOWN qemu.
>
> So long as this test is attempting to reboot, the correct choice would
> be to WAIT for the VM to exit. However, since that's broken, we should
> SHUTDOWN instead.
>
> SHUTDOWN is indeed what already happens when the test performs teardown,
> however, if anyone fixes cubieboard reboot in the future, this test will
> develop a new race condition that might be hard to debug.
>
> Therefore: remove the reboot test and make it obvious that the VM is
> still running when the test concludes, where the test teardown will do
> the right thing.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
> tests/acceptance/boot_linux_console.py | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
Reviewed-by: Cleber Rosa <crosa@redhat.com>
Tested-by: Cleber Rosa <crosa@redhat.com>
signature.asc
Description: PGP signature
[PATCH v5 12/12] python/machine.py: change default wait timeout to 3 seconds, John Snow, 2020/07/10
[PATCH v5 11/12] python/machine.py: re-add sigkill warning suppression, John Snow, 2020/07/10