[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] docker.py: fix fetching of FROM layers
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH] docker.py: fix fetching of FROM layers |
|
Date: |
Mon, 13 Jul 2020 19:46:57 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
On 7/13/20 4:58 PM, Alex Bennée wrote:
> This worked on a system that was already bootstrapped because the
> stage 2 images already existed even if they wouldn't be used. What we
> should have pulled down was the FROM line containers first because
> building on gitlab doesn't have the advantage of using our build
> system to build the pre-requisite bits.
>
> We still pull the image we want to build just in case we can use the
> cached data.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> tests/docker/docker.py | 16 +++++++++++-----
> 1 file changed, 11 insertions(+), 5 deletions(-)
>
Tested-by: Philippe Mathieu-Daudé <f4bug@amsat.org>