Re: [PATCH] docker.py: fix fetching of FROM layers

[Daniel P . Berrangé]

On Mon, Jul 13, 2020 at 03:58:01PM +0100, Alex Bennée wrote:
> This worked on a system that was already bootstrapped because the
> stage 2 images already existed even if they wouldn't be used. What we
> should have pulled down was the FROM line containers first because
> building on gitlab doesn't have the advantage of using our build
> system to build the pre-requisite bits.
> 
> We still pull the image we want to build just in case we can use the
> cached data.
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>  tests/docker/docker.py | 16 +++++++++++-----
>  1 file changed, 11 insertions(+), 5 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|