[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 04/12] python/machine.py: Perform early cleanup for wait()
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH v5 04/12] python/machine.py: Perform early cleanup for wait() calls, too |
|
Date: |
Mon, 13 Jul 2020 19:24:12 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
On 7/10/20 7:06 AM, John Snow wrote:
> This is primarily for consistency, and is a step towards wait() and
> shutdown() sharing the same implementation so that the two cleanup paths
> cannot diverge.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
> python/qemu/machine.py | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/python/qemu/machine.py b/python/qemu/machine.py
> index 4280aab380..cac466fbe6 100644
> --- a/python/qemu/machine.py
> +++ b/python/qemu/machine.py
> @@ -369,6 +369,7 @@ def wait(self):
> """
> Wait for the VM to power off
> """
> + self._early_cleanup()
> self._popen.wait()
> self._post_shutdown()
>
>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
- [PATCH v5 01/12] python/machine.py: consolidate _post_shutdown(), (continued)
- [PATCH v5 01/12] python/machine.py: consolidate _post_shutdown(), John Snow, 2020/07/10
- [PATCH v5 03/12] python/machine.py: Add _early_cleanup hook, John Snow, 2020/07/10
- [PATCH v5 05/12] python/machine.py: Prohibit multiple shutdown() calls, John Snow, 2020/07/10
- [PATCH v5 04/12] python/machine.py: Perform early cleanup for wait() calls, too, John Snow, 2020/07/10
- [PATCH v5 06/12] python/machine.py: Add a configurable timeout to shutdown(), John Snow, 2020/07/10
- [PATCH v5 07/12] python/machine.py: Make wait() call shutdown(), John Snow, 2020/07/10
- [PATCH v5 08/12] tests/acceptance: wait() instead of shutdown() where appropriate, John Snow, 2020/07/10