[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 05/12] python/machine.py: Prohibit multiple shutdown() cal
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH v5 05/12] python/machine.py: Prohibit multiple shutdown() calls |
|
Date: |
Mon, 13 Jul 2020 11:27:41 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
On 7/10/20 7:06 AM, John Snow wrote:
> If the VM is not launched, don't try to shut it down. As a change,
> _post_shutdown now unconditionally also calls _early_cleanup in order to
> offer comprehensive object cleanup in failure cases.
>
> As a courtesy, treat it as a NOP instead of rejecting it as an
> error. This is slightly nicer for acceptance tests where vm.shutdown()
> is issued unconditionally in tearDown callbacks.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
> python/qemu/machine.py | 14 +++++++++++++-
> 1 file changed, 13 insertions(+), 1 deletion(-)
>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
- [PATCH v5 02/12] python/machine.py: Close QMP socket in cleanup, (continued)
- [PATCH v5 02/12] python/machine.py: Close QMP socket in cleanup, John Snow, 2020/07/10
- [PATCH v5 01/12] python/machine.py: consolidate _post_shutdown(), John Snow, 2020/07/10
- [PATCH v5 03/12] python/machine.py: Add _early_cleanup hook, John Snow, 2020/07/10
- [PATCH v5 05/12] python/machine.py: Prohibit multiple shutdown() calls, John Snow, 2020/07/10
- [PATCH v5 04/12] python/machine.py: Perform early cleanup for wait() calls, too, John Snow, 2020/07/10
- [PATCH v5 06/12] python/machine.py: Add a configurable timeout to shutdown(), John Snow, 2020/07/10
- [PATCH v5 07/12] python/machine.py: Make wait() call shutdown(), John Snow, 2020/07/10