[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PULL 04/10] build: fix device module builds
From: |
Claudio Fontana |
Subject: |
Re: [PULL 04/10] build: fix device module builds |
Date: |
Fri, 3 Jul 2020 11:01:43 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 |
On 7/2/20 2:20 PM, Gerd Hoffmann wrote:
> See comment. Feels quite hackish. Better ideas anyone?
>
A better idea could be to investigate what and why gets into the variable.
I guess at this point we will need to revisit this later on.
CLaudio
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> Message-id: 20200624131045.14512-5-kraxel@redhat.com
> ---
> Makefile.target | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/Makefile.target b/Makefile.target
> index 8ed1eba95b9c..c70325df5796 100644
> --- a/Makefile.target
> +++ b/Makefile.target
> @@ -179,6 +179,13 @@ endif # CONFIG_SOFTMMU
> dummy := $(call unnest-vars,,obj-y)
> all-obj-y := $(obj-y)
>
> +#
> +# common-obj-m has some crap here, probably as side effect from
> +# filling obj-y. Clear it. Fixes suspious dependency errors when
> +# building devices as modules.
> +#
> +common-obj-m :=
> +> include $(SRC_PATH)/Makefile.objs
> dummy := $(call unnest-vars,.., \
> authz-obj-y \
>
[PULL 03/10] qdev: device module support, Gerd Hoffmann, 2020/07/02
[PULL 05/10] ccid: build smartcard as module, Gerd Hoffmann, 2020/07/02
[PULL 01/10] module: qom module support, Gerd Hoffmann, 2020/07/02
[PULL 06/10] usb: build usb-redir as module, Gerd Hoffmann, 2020/07/02
[PULL 10/10] chardev: enable modules, use for braille, Gerd Hoffmann, 2020/07/02
[PULL 08/10] vga: build virtio-gpu only once, Gerd Hoffmann, 2020/07/02
[PULL 07/10] vga: build qxl as module, Gerd Hoffmann, 2020/07/02