Re: [PATCH v2 0/6] hw/mips/malta: Add the 'malta-strict' machine, matching Malta hardware

[Daniel P . Berrangé]

On Tue, Jun 30, 2020 at 05:38:25PM +0200, Aleksandar Markovic wrote:
> уто, 30. јун 2020. у 16:52 Philippe Mathieu-Daudé <f4bug@amsat.org> је
> написао/ла:
> >
> > Hi,
> >
> > This series add a new 'malta-strict' machine, that aims to properly
> > model the real hardware (which is not what the current 'malta'
> > machine models).
> >
> > As a bonus for Debian builders, a 'malta-unleashed' machine RFC
> > patch is included. This might start another endless discussion
> > upstream, but this is not the point of, so I still include it
> > for people to test. The rest of the series is candidate for merging
> > in mainstream QEMU.
> >
> > Philippe Mathieu-Daudé (6):
> >   hw/mips/malta: Trivial code movement
> >   hw/mips/malta: Register the machine as a TypeInfo
> >   hw/mips/malta: Introduce MaltaMachineClass::max_ramsize
> >   hw/mips/malta: Introduce the 'malta-strict' machine
> >   hw/mips/malta: Verify malta-strict machine uses correct DIMM sizes
> >   hw/mips/malta: Introduce the 'malta-unleashed' 64-bit machine
> >
> >  hw/mips/malta.c | 125 ++++++++++++++++++++++++++++++++++++++++++------
> >  1 file changed, 111 insertions(+), 14 deletions(-)
> >
> > --
> 
> This whole series is based on idea of emulating physically
> non-existing feature, and as such violates the fundamental principles
> of QEMU.

On x86 we model a i440fx from 1995. Max RAM in 1995 was on the order
of 10's of MB, but we run it with *multi-TB* of RAM in QEMU. There's
examples of this all over QEMU.

> As such, not acceptable for upstreaming.

I think this is quite unreasonable, especially considering this series is
addressing a real world problem that users of QEMU malta are facing with
insufficient RAM. QEMU exists to help users get their work done

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|