[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 05/11] rules.mak: Add base-arch() rule
|
From: |
Richard Henderson |
|
Subject: |
Re: [PATCH v4 05/11] rules.mak: Add base-arch() rule |
|
Date: |
Sun, 31 May 2020 19:13:40 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 |
On 5/22/20 9:37 AM, Philippe Mathieu-Daudé wrote:
> + $(if $(call startwith,risc,$1),risc,\
Should be "riscv" not "risc". Especially the substitution.
> + $(if $(call startwith,aarch64,$1),arm,\
> + $(if $(call startwith,x86_64,$1),i386,\
We don't have an exact equality function?
r~
- [PATCH v4 00/11] accel: Allow targets to use Kconfig, Philippe Mathieu-Daudé, 2020/05/22
- [PATCH v4 01/11] MAINTAINERS: Fix KVM path expansion glob, Philippe Mathieu-Daudé, 2020/05/22
- [PATCH v4 02/11] MAINTAINERS: Add an 'overall' entry for accelerators, Philippe Mathieu-Daudé, 2020/05/22
- [PATCH v4 03/11] MAINTAINERS: Add an entry for the HAX accelerator, Philippe Mathieu-Daudé, 2020/05/22
- [PATCH v4 04/11] rules.mak: Add startwith() rule, Philippe Mathieu-Daudé, 2020/05/22
- [PATCH v4 05/11] rules.mak: Add base-arch() rule, Philippe Mathieu-Daudé, 2020/05/22
- Re: [PATCH v4 05/11] rules.mak: Add base-arch() rule,
Richard Henderson <=
- [PATCH v4 06/11] Makefile: Remove dangerous EOL trailing backslash, Philippe Mathieu-Daudé, 2020/05/22
- [PATCH v4 07/11] Makefile: Write MINIKCONF variables as one entry per line, Philippe Mathieu-Daudé, 2020/05/22
- [PATCH v4 08/11] accel/Kconfig: Extract accel selectors into their own config, Philippe Mathieu-Daudé, 2020/05/22
- [PATCH v4 09/11] accel/Kconfig: Add the TCG selector, Philippe Mathieu-Daudé, 2020/05/22
- [PATCH v4 10/11] Makefile: Allow target-specific optional Kconfig, Philippe Mathieu-Daudé, 2020/05/22
- [PATCH v4 11/11] accel/tcg: Add stub for probe_access(), Philippe Mathieu-Daudé, 2020/05/22