Re: [PATCH v2 00/58] qdev: Rework how we plug into the parent bus

[no-reply]

Patchew URL: 20200529134523.8477-1-armbru@redhat.com/">https://patchew.org/QEMU/20200529134523.8477-1-armbru@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20200529134523.8477-1-armbru@redhat.com
Subject: [PATCH v2 00/58] qdev: Rework how we plug into the parent bus
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

From https://github.com/patchew-project/qemu
 - [tag update]      patchew/20200529134523.8477-1-armbru@redhat.com -> 
patchew/20200529134523.8477-1-armbru@redhat.com
Switched to a new branch 'test'
6ab17ba MAINTAINERS: Make section QOM cover hw/core/*bus.c as well
2ff6640 qdev: qdev_init_nofail() is now unused, drop
ef169cb qdev: Convert bus-less devices to qdev_realize() with Coccinelle
c5fb207 qdev: Use qdev_realize() in qdev_device_add()
53c9eb7 qdev: Make qdev_realize() support bus-less devices
a24f37d s390x/event-facility: Simplify creation of SCLP event devices
e98ec98 microbit: Eliminate two local variables in microbit_init()
de2d573 sysbus: sysbus_init_child_obj() is now unused, drop
f4e9821 sysbus: Convert qdev_set_parent_bus() use with Coccinelle, part 4
bb63878 sysbus: Convert qdev_set_parent_bus() use with Coccinelle, part 3
284c740 sysbus: Convert qdev_set_parent_bus() use with Coccinelle, part 2
8968c58 sysbus: Convert qdev_set_parent_bus() use with Coccinelle, part 1
d5b3267 qdev: Drop qdev_realize() support for null bus
366dd6c sysbus: Convert to sysbus_realize() etc. with Coccinelle
5d8cf38 sysbus: New sysbus_realize(), sysbus_realize_and_unref()
2e4518c sysbus: Tidy up sysbus_init_child_obj()'s @childsize arg, part 2
cf3ac8b hw/arm/armsse: Pass correct child size to sysbus_init_child_obj()
a7d0014 sysbus: Tidy up sysbus_init_child_obj()'s @childsize arg, part 1
20429c9 microbit: Tidy up sysbus_init_child_obj() @child argument
23d67a5 sysbus: Drop useless OBJECT() in sysbus_init_child_obj() calls
31aeda4 macio: Eliminate macio_init_child_obj()
a4f9cab macio: Convert use of qdev_set_parent_bus()
eee0ca9 qom: Less verbose object_initialize_child()
f8dcb00 qom: Tidy up a few object_initialize_child() calls
bd186c9 auxbus: Eliminate aux_create_slave()
404dc52 auxbus: Convert a use of qdev_set_parent_bus()
de8ce5f auxbus: New aux_bus_realize(), pairing with aux_bus_init()
083ee04 auxbus: Rename aux_init_bus() to aux_bus_init()
4ac8676 qdev: qdev_create(), qdev_try_create() are now unused, drop
e6cc739 usb: Eliminate usb_try_create_simple()
9f21e80 usb: usb_create() is now unused, drop
0177184 usb: Convert uses of usb_create()
d4128a5 usb: New usb_new(), usb_realize_and_unref()
4e2dc9b ssi: ssi_create_slave_no_init() is now unused, drop
7e18650 ssi: Convert last use of ssi_create_slave_no_init() manually
d5646b2 ssi: Convert uses of ssi_create_slave_no_init() with Coccinelle
092d4f1 ssi: ssi_auto_connect_slaves() never does anything, drop
bae4ea1 isa: isa_create(), isa_try_create() are now unused, drop
e6e38d5 isa: Convert uses of isa_create(), isa_try_create() manually
0dde89d isa: Convert uses of isa_create() with Coccinelle
d09e209 isa: New isa_new(), isa_realize_and_unref() etc.
c36b876 pci: pci_create(), pci_create_multifunction() are now unused, drop
9464192 pci: Convert uses of pci_create() etc. manually
dfb652b pci: Convert uses of pci_create() etc. with Coccinelle
2d210af hw/ppc: Eliminate two superfluous QOM casts
b9af5c7 pci: New pci_new(), pci_realize_and_unref() etc.
20700a7 qdev: Convert uses of qdev_set_parent_bus() manually
dd8ce29 qdev: Convert uses of qdev_set_parent_bus() with Coccinelle
cbeac45 qdev: Convert uses of qdev_create() manually
a3830a0 qdev: Convert uses of qdev_create() with Coccinelle
b3fc907 qdev: Convert to qdev_unrealize() manually
1e4b57b qdev: Convert to qdev_unrealize() with Coccinelle
20d2240 qdev: Convert to qbus_realize(), qbus_unrealize()
af49a25 qdev: Put qdev_new() to use with Coccinelle
a62e83f qdev: New qdev_new(), qdev_realize(), etc.
6766bcb Revert "hw/versatile: realize the PCI root bus as part of the versatile 
init"
35d8550 Revert "hw/prep: realize the PCI root bus as part of the prep init"
9cfc5ab qdev: Rename qbus_realize() to qbus_init()

=== OUTPUT BEGIN ===
1/58 Checking commit 9cfc5ab931a7 (qdev: Rename qbus_realize() to qbus_init())
2/58 Checking commit 35d8550db6e2 (Revert "hw/prep: realize the PCI root bus as 
part of the prep init")
3/58 Checking commit 6766bcb8b645 (Revert "hw/versatile: realize the PCI root 
bus as part of the versatile init")
4/58 Checking commit a62e83f0ba1a (qdev: New qdev_new(), qdev_realize(), etc.)
5/58 Checking commit af49a25a9a73 (qdev: Put qdev_new() to use with Coccinelle)
6/58 Checking commit 20d2240056ba (qdev: Convert to qbus_realize(), 
qbus_unrealize())
7/58 Checking commit 1e4b57ba4cf9 (qdev: Convert to qdev_unrealize() with 
Coccinelle)
8/58 Checking commit b3fc907924a6 (qdev: Convert to qdev_unrealize() manually)
9/58 Checking commit a3830a03812e (qdev: Convert uses of qdev_create() with 
Coccinelle)
10/58 Checking commit cbeac45a59cb (qdev: Convert uses of qdev_create() 
manually)
11/58 Checking commit dd8ce29abe63 (qdev: Convert uses of qdev_set_parent_bus() 
with Coccinelle)
12/58 Checking commit 20700a719958 (qdev: Convert uses of qdev_set_parent_bus() 
manually)
13/58 Checking commit b9af5c7cdadb (pci: New pci_new(), pci_realize_and_unref() 
etc.)
14/58 Checking commit 2d210af6278f (hw/ppc: Eliminate two superfluous QOM casts)
15/58 Checking commit dfb652bc680d (pci: Convert uses of pci_create() etc. with 
Coccinelle)
16/58 Checking commit 946419234024 (pci: Convert uses of pci_create() etc. 
manually)
17/58 Checking commit c36b87606a08 (pci: pci_create(), 
pci_create_multifunction() are now unused, drop)
18/58 Checking commit d09e209b86e0 (isa: New isa_new(), isa_realize_and_unref() 
etc.)
19/58 Checking commit 0dde89d7c13d (isa: Convert uses of isa_create() with 
Coccinelle)
ERROR: do not use C99 // comments
#384: FILE: hw/rtc/m48t59-isa.c:74:
+        ISADevice *isa_dev; // TODO move

ERROR: do not use C99 // comments
#420: FILE: hw/sparc64/sun4u.c:341:
+    ISADevice *isa_dev; // TODO move

total: 2 errors, 0 warnings, 348 lines checked

Patch 19/58 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

20/58 Checking commit e6e38d544dba (isa: Convert uses of isa_create(), 
isa_try_create() manually)
21/58 Checking commit bae4ea1feef9 (isa: isa_create(), isa_try_create() are now 
unused, drop)
22/58 Checking commit 092d4f1ac851 (ssi: ssi_auto_connect_slaves() never does 
anything, drop)
23/58 Checking commit d5646b2a7924 (ssi: Convert uses of 
ssi_create_slave_no_init() with Coccinelle)
24/58 Checking commit 7e1865019bd5 (ssi: Convert last use of 
ssi_create_slave_no_init() manually)
25/58 Checking commit 4e2dc9ba647b (ssi: ssi_create_slave_no_init() is now 
unused, drop)
26/58 Checking commit d4128a503d17 (usb: New usb_new(), usb_realize_and_unref())
27/58 Checking commit 017718456f64 (usb: Convert uses of usb_create())
28/58 Checking commit 9f21e803c95e (usb: usb_create() is now unused, drop)
29/58 Checking commit e6cc739dff4b (usb: Eliminate usb_try_create_simple())
30/58 Checking commit 4ac8676ab5ce (qdev: qdev_create(), qdev_try_create() are 
now unused, drop)
31/58 Checking commit 083ee04a41ba (auxbus: Rename aux_init_bus() to 
aux_bus_init())
32/58 Checking commit de8ce5f7a784 (auxbus: New aux_bus_realize(), pairing with 
aux_bus_init())
33/58 Checking commit 404dc52e0539 (auxbus: Convert a use of 
qdev_set_parent_bus())
34/58 Checking commit bd186c9404f7 (auxbus: Eliminate aux_create_slave())
35/58 Checking commit f8dcb001d2c5 (qom: Tidy up a few 
object_initialize_child() calls)
36/58 Checking commit eee0ca94ef31 (qom: Less verbose object_initialize_child())
37/58 Checking commit a4f9cab09dcd (macio: Convert use of qdev_set_parent_bus())
38/58 Checking commit 31aeda4f96d3 (macio: Eliminate macio_init_child_obj())
39/58 Checking commit 23d67a51f803 (sysbus: Drop useless OBJECT() in 
sysbus_init_child_obj() calls)
WARNING: line over 80 characters
#144: FILE: hw/arm/aspeed_ast2600.c:221:
+                          &s->emmc.slots[0], sizeof(s->emmc.slots[0]), 
TYPE_SYSBUS_SDHCI);

total: 0 errors, 1 warnings, 238 lines checked

Patch 39/58 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
40/58 Checking commit 20429c92daee (microbit: Tidy up sysbus_init_child_obj() 
@child argument)
41/58 Checking commit a7d0014faf41 (sysbus: Tidy up sysbus_init_child_obj()'s 
@childsize arg, part 1)
42/58 Checking commit cf3ac8bb20fc (hw/arm/armsse: Pass correct child size to 
sysbus_init_child_obj())
43/58 Checking commit 2e4518c3efc6 (sysbus: Tidy up sysbus_init_child_obj()'s 
@childsize arg, part 2)
44/58 Checking commit 5d8cf382708c (sysbus: New sysbus_realize(), 
sysbus_realize_and_unref())
45/58 Checking commit 366dd6c2ee62 (sysbus: Convert to sysbus_realize() etc. 
with Coccinelle)
46/58 Checking commit d5b3267d1d3d (qdev: Drop qdev_realize() support for null 
bus)
47/58 Checking commit 8968c58bc12f (sysbus: Convert qdev_set_parent_bus() use 
with Coccinelle, part 1)
48/58 Checking commit 284c740f202f (sysbus: Convert qdev_set_parent_bus() use 
with Coccinelle, part 2)
49/58 Checking commit bb6387808750 (sysbus: Convert qdev_set_parent_bus() use 
with Coccinelle, part 3)
50/58 Checking commit f4e982128f29 (sysbus: Convert qdev_set_parent_bus() use 
with Coccinelle, part 4)
51/58 Checking commit de2d573cc85d (sysbus: sysbus_init_child_obj() is now 
unused, drop)
52/58 Checking commit e98ec982bdb7 (microbit: Eliminate two local variables in 
microbit_init())
53/58 Checking commit a24f37d08052 (s390x/event-facility: Simplify creation of 
SCLP event devices)
54/58 Checking commit 53c9eb722a78 (qdev: Make qdev_realize() support bus-less 
devices)
55/58 Checking commit c5fb207ea220 (qdev: Use qdev_realize() in 
qdev_device_add())
56/58 Checking commit ef169cb2094b (qdev: Convert bus-less devices to 
qdev_realize() with Coccinelle)
57/58 Checking commit 2ff66406a79b (qdev: qdev_init_nofail() is now unused, 
drop)
58/58 Checking commit 6ab17bae2d34 (MAINTAINERS: Make section QOM cover 
hw/core/*bus.c as well)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20200529134523.8477-1-armbru@redhat.com/testing.checkpatch/?type=message">http://patchew.org/logs/20200529134523.8477-1-armbru@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com