Re: [PATCH v2 00/58] qdev: Rework how we plug into the parent bus

[no-reply]

Patchew URL: 20200529134523.8477-1-armbru@redhat.com/">https://patchew.org/QEMU/20200529134523.8477-1-armbru@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20200529134523.8477-1-armbru@redhat.com
Subject: [PATCH v2 00/58] qdev: Rework how we plug into the parent bus
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
35d2186 MAINTAINERS: Make section QOM cover hw/core/*bus.c as well
b5abcc7 qdev: qdev_init_nofail() is now unused, drop
f8fd657 qdev: Convert bus-less devices to qdev_realize() with Coccinelle
7cbb4a0 qdev: Use qdev_realize() in qdev_device_add()
90508ef qdev: Make qdev_realize() support bus-less devices
ac2c79d s390x/event-facility: Simplify creation of SCLP event devices
c9df786 microbit: Eliminate two local variables in microbit_init()
7de4365 sysbus: sysbus_init_child_obj() is now unused, drop
6deeaef sysbus: Convert qdev_set_parent_bus() use with Coccinelle, part 4
166f451 sysbus: Convert qdev_set_parent_bus() use with Coccinelle, part 3
817d04d sysbus: Convert qdev_set_parent_bus() use with Coccinelle, part 2
35ed426 sysbus: Convert qdev_set_parent_bus() use with Coccinelle, part 1
efb76a5 qdev: Drop qdev_realize() support for null bus
e52c78b sysbus: Convert to sysbus_realize() etc. with Coccinelle
b165b5e sysbus: New sysbus_realize(), sysbus_realize_and_unref()
c4fa2dd sysbus: Tidy up sysbus_init_child_obj()'s @childsize arg, part 2
a65d26d hw/arm/armsse: Pass correct child size to sysbus_init_child_obj()
c02d099 sysbus: Tidy up sysbus_init_child_obj()'s @childsize arg, part 1
874a6e0 microbit: Tidy up sysbus_init_child_obj() @child argument
1c1983c sysbus: Drop useless OBJECT() in sysbus_init_child_obj() calls
d3da8f6 macio: Eliminate macio_init_child_obj()
a6fbb72 macio: Convert use of qdev_set_parent_bus()
cd787ca qom: Less verbose object_initialize_child()
5fc1ec3 qom: Tidy up a few object_initialize_child() calls
b70e5d6 auxbus: Eliminate aux_create_slave()
a553d10 auxbus: Convert a use of qdev_set_parent_bus()
332ba93 auxbus: New aux_bus_realize(), pairing with aux_bus_init()
760bbfe auxbus: Rename aux_init_bus() to aux_bus_init()
8849af5 qdev: qdev_create(), qdev_try_create() are now unused, drop
7bf4596 usb: Eliminate usb_try_create_simple()
7879a1b usb: usb_create() is now unused, drop
4ad74fb usb: Convert uses of usb_create()
bdabeda usb: New usb_new(), usb_realize_and_unref()
66d155d ssi: ssi_create_slave_no_init() is now unused, drop
eccc542 ssi: Convert last use of ssi_create_slave_no_init() manually
abe5193 ssi: Convert uses of ssi_create_slave_no_init() with Coccinelle
a0d9945 ssi: ssi_auto_connect_slaves() never does anything, drop
ed8709f isa: isa_create(), isa_try_create() are now unused, drop
8325fc1 isa: Convert uses of isa_create(), isa_try_create() manually
e33f3fd isa: Convert uses of isa_create() with Coccinelle
37f2e28 isa: New isa_new(), isa_realize_and_unref() etc.
76bd83a pci: pci_create(), pci_create_multifunction() are now unused, drop
e8ce95a pci: Convert uses of pci_create() etc. manually
b876876 pci: Convert uses of pci_create() etc. with Coccinelle
7161985 hw/ppc: Eliminate two superfluous QOM casts
a9d8154 pci: New pci_new(), pci_realize_and_unref() etc.
5d6768f qdev: Convert uses of qdev_set_parent_bus() manually
60523d1 qdev: Convert uses of qdev_set_parent_bus() with Coccinelle
01819c3 qdev: Convert uses of qdev_create() manually
4d94520c qdev: Convert uses of qdev_create() with Coccinelle
d576e66 qdev: Convert to qdev_unrealize() manually
d2e42f8 qdev: Convert to qdev_unrealize() with Coccinelle
e8618d0 qdev: Convert to qbus_realize(), qbus_unrealize()
08ab272e qdev: Put qdev_new() to use with Coccinelle
22a047a qdev: New qdev_new(), qdev_realize(), etc.
4eabae2 Revert "hw/versatile: realize the PCI root bus as part of the versatile 
init"
e75024d Revert "hw/prep: realize the PCI root bus as part of the prep init"
5ac175a qdev: Rename qbus_realize() to qbus_init()

=== OUTPUT BEGIN ===
1/58 Checking commit 5ac175a0ddb4 (qdev: Rename qbus_realize() to qbus_init())
2/58 Checking commit e75024d0e9a7 (Revert "hw/prep: realize the PCI root bus as 
part of the prep init")
3/58 Checking commit 4eabae2c9ff8 (Revert "hw/versatile: realize the PCI root 
bus as part of the versatile init")
4/58 Checking commit 22a047a6e8b6 (qdev: New qdev_new(), qdev_realize(), etc.)
5/58 Checking commit 08ab272e5d44 (qdev: Put qdev_new() to use with Coccinelle)
6/58 Checking commit e8618d00d5a1 (qdev: Convert to qbus_realize(), 
qbus_unrealize())
7/58 Checking commit d2e42f8ae924 (qdev: Convert to qdev_unrealize() with 
Coccinelle)
8/58 Checking commit d576e6651852 (qdev: Convert to qdev_unrealize() manually)
9/58 Checking commit 4d94520c7fb5 (qdev: Convert uses of qdev_create() with 
Coccinelle)
10/58 Checking commit 01819c395ec3 (qdev: Convert uses of qdev_create() 
manually)
11/58 Checking commit 60523d193f4b (qdev: Convert uses of qdev_set_parent_bus() 
with Coccinelle)
12/58 Checking commit 5d6768f54514 (qdev: Convert uses of qdev_set_parent_bus() 
manually)
13/58 Checking commit a9d81542adb1 (pci: New pci_new(), pci_realize_and_unref() 
etc.)
14/58 Checking commit 7161985e36f7 (hw/ppc: Eliminate two superfluous QOM casts)
15/58 Checking commit b8768760337e (pci: Convert uses of pci_create() etc. with 
Coccinelle)
16/58 Checking commit e8ce95ae8070 (pci: Convert uses of pci_create() etc. 
manually)
17/58 Checking commit 76bd83ae156f (pci: pci_create(), 
pci_create_multifunction() are now unused, drop)
18/58 Checking commit 37f2e281b9dc (isa: New isa_new(), isa_realize_and_unref() 
etc.)
19/58 Checking commit e33f3fd2e99d (isa: Convert uses of isa_create() with 
Coccinelle)
ERROR: do not use C99 // comments
#384: FILE: hw/rtc/m48t59-isa.c:74:
+        ISADevice *isa_dev; // TODO move

ERROR: do not use C99 // comments
#420: FILE: hw/sparc64/sun4u.c:341:
+    ISADevice *isa_dev; // TODO move

total: 2 errors, 0 warnings, 348 lines checked

Patch 19/58 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

20/58 Checking commit 8325fc1d09cb (isa: Convert uses of isa_create(), 
isa_try_create() manually)
21/58 Checking commit ed8709f374e2 (isa: isa_create(), isa_try_create() are now 
unused, drop)
22/58 Checking commit a0d9945a52c2 (ssi: ssi_auto_connect_slaves() never does 
anything, drop)
23/58 Checking commit abe5193ac773 (ssi: Convert uses of 
ssi_create_slave_no_init() with Coccinelle)
24/58 Checking commit eccc542bc734 (ssi: Convert last use of 
ssi_create_slave_no_init() manually)
25/58 Checking commit 66d155dc5356 (ssi: ssi_create_slave_no_init() is now 
unused, drop)
26/58 Checking commit bdabeda16b8b (usb: New usb_new(), usb_realize_and_unref())
27/58 Checking commit 4ad74fb7b4dd (usb: Convert uses of usb_create())
28/58 Checking commit 7879a1bf0f80 (usb: usb_create() is now unused, drop)
29/58 Checking commit 7bf459696e13 (usb: Eliminate usb_try_create_simple())
30/58 Checking commit 8849af5b26d7 (qdev: qdev_create(), qdev_try_create() are 
now unused, drop)
31/58 Checking commit 760bbfe85529 (auxbus: Rename aux_init_bus() to 
aux_bus_init())
32/58 Checking commit 332ba93642f1 (auxbus: New aux_bus_realize(), pairing with 
aux_bus_init())
33/58 Checking commit a553d109c610 (auxbus: Convert a use of 
qdev_set_parent_bus())
34/58 Checking commit b70e5d6b08e0 (auxbus: Eliminate aux_create_slave())
35/58 Checking commit 5fc1ec3c2182 (qom: Tidy up a few 
object_initialize_child() calls)
36/58 Checking commit cd787ca34447 (qom: Less verbose object_initialize_child())
37/58 Checking commit a6fbb724e7b6 (macio: Convert use of qdev_set_parent_bus())
38/58 Checking commit d3da8f631f47 (macio: Eliminate macio_init_child_obj())
39/58 Checking commit 1c1983c516db (sysbus: Drop useless OBJECT() in 
sysbus_init_child_obj() calls)
WARNING: line over 80 characters
#144: FILE: hw/arm/aspeed_ast2600.c:221:
+                          &s->emmc.slots[0], sizeof(s->emmc.slots[0]), 
TYPE_SYSBUS_SDHCI);

total: 0 errors, 1 warnings, 238 lines checked

Patch 39/58 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
40/58 Checking commit 874a6e009b2c (microbit: Tidy up sysbus_init_child_obj() 
@child argument)
41/58 Checking commit c02d099b14d8 (sysbus: Tidy up sysbus_init_child_obj()'s 
@childsize arg, part 1)
42/58 Checking commit a65d26d31c58 (hw/arm/armsse: Pass correct child size to 
sysbus_init_child_obj())
43/58 Checking commit c4fa2dd20d7b (sysbus: Tidy up sysbus_init_child_obj()'s 
@childsize arg, part 2)
44/58 Checking commit b165b5e5b293 (sysbus: New sysbus_realize(), 
sysbus_realize_and_unref())
45/58 Checking commit e52c78bf229b (sysbus: Convert to sysbus_realize() etc. 
with Coccinelle)
46/58 Checking commit efb76a577cd4 (qdev: Drop qdev_realize() support for null 
bus)
47/58 Checking commit 35ed4267918e (sysbus: Convert qdev_set_parent_bus() use 
with Coccinelle, part 1)
48/58 Checking commit 817d04dac4b8 (sysbus: Convert qdev_set_parent_bus() use 
with Coccinelle, part 2)
49/58 Checking commit 166f451f2fd6 (sysbus: Convert qdev_set_parent_bus() use 
with Coccinelle, part 3)
50/58 Checking commit 6deeaef29eb1 (sysbus: Convert qdev_set_parent_bus() use 
with Coccinelle, part 4)
51/58 Checking commit 7de436543ef9 (sysbus: sysbus_init_child_obj() is now 
unused, drop)
52/58 Checking commit c9df7868a550 (microbit: Eliminate two local variables in 
microbit_init())
53/58 Checking commit ac2c79d66173 (s390x/event-facility: Simplify creation of 
SCLP event devices)
54/58 Checking commit 90508ef845f7 (qdev: Make qdev_realize() support bus-less 
devices)
55/58 Checking commit 7cbb4a0cb686 (qdev: Use qdev_realize() in 
qdev_device_add())
56/58 Checking commit f8fd657efef4 (qdev: Convert bus-less devices to 
qdev_realize() with Coccinelle)
57/58 Checking commit b5abcc75ae8b (qdev: qdev_init_nofail() is now unused, 
drop)
58/58 Checking commit 35d2186328c9 (MAINTAINERS: Make section QOM cover 
hw/core/*bus.c as well)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20200529134523.8477-1-armbru@redhat.com/testing.checkpatch/?type=message">http://patchew.org/logs/20200529134523.8477-1-armbru@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com