Re: [PATCH 1/3] qapi: Make @associativity, @policy and @line of NumaHmatCacheOptions optional

[Igor Mammedov]

On Fri, 29 May 2020 15:33:46 +0200
Michal Privoznik <mprivozn@redhat.com> wrote:

> The documentation to `-numa hmat-cache` says that @node-id, @size
> and @level are the only required attributes. The rest
> (@associativity, @policy and @line) is optional. Well, not quite
> - if I try to start QEMU with only the three required attributes
> defined the QAPI code is complaining about associativity missing.

indeed, they are marked as optional CLI arguments but we don't have
a code that would make them as optional. And I'd prefer docs fixed
instead of introducing default values handling here.


> Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
> ---
>  qapi/machine.json | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/qapi/machine.json b/qapi/machine.json
> index ff7b5032e3..952784f8ba 100644
> --- a/qapi/machine.json
> +++ b/qapi/machine.json
> @@ -723,9 +723,9 @@
>     'node-id': 'uint32',
>     'size': 'size',
>     'level': 'uint8',
> -   'associativity': 'HmatCacheAssociativity',
> -   'policy': 'HmatCacheWritePolicy',
> -   'line': 'uint16' }}
> +   '*associativity': 'HmatCacheAssociativity',
> +   '*policy': 'HmatCacheWritePolicy',
> +   '*line': 'uint16' }}
>  
>  ##
>  # @HostMemPolicy: