Re: [PATCH v1 0/3] some linux-user guest_base fixes

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Subject: [PATCH  v1 0/3] some linux-user guest_base fixes
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

From https://github.com/patchew-project/qemu
 - [tag update]      patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
a537e13 tests/tcg: add simple commpage test case
26c424e linux-user: deal with address wrap for ARM_COMMPAGE on 32 bit
8825cb1 linux-user: provide fallback pgd_find_hole for bare chroots

=== OUTPUT BEGIN ===
1/3 Checking commit 8825cb148fa8 (linux-user: provide fallback pgd_find_hole 
for bare chroots)
WARNING: line over 80 characters
#44: FILE: linux-user/elfload.c:2114:
+static uintptr_t pgd_find_hole_fallback(uintptr_t guest_size, uintptr_t brk, 
long align)

total: 0 errors, 1 warnings, 60 lines checked

Patch 1/3 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/3 Checking commit 26c424e346df (linux-user: deal with address wrap for 
ARM_COMMPAGE on 32 bit)
3/3 Checking commit a537e13dbea5 (tests/tcg: add simple commpage test case)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#28: 
new file mode 100644

ERROR: Use of volatile is usually wrong, please add a comment
#57: FILE: tests/tcg/arm/commpage.c:25:
+typedef int (cmpxchg_fn)(int oldval, int newval, volatile int *ptr);

ERROR: Use of volatile is usually wrong, please add a comment
#63: FILE: tests/tcg/arm/commpage.c:31:
+                           volatile int64_t *ptr);

total: 2 errors, 1 warnings, 69 lines checked

Patch 3/3 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden