[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 09/24] macio: Fix to realize "mos6522-cuda" and "mos6522-pmu"
|
From: |
Markus Armbruster |
|
Subject: |
Re: [PATCH 09/24] macio: Fix to realize "mos6522-cuda" and "mos6522-pmu" devices |
|
Date: |
Wed, 27 May 2020 16:12:07 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Peter Maydell <address@hidden> writes:
[...]
> Since we init the device with sysbus_init_child_obj() and
> we're in a position here to propagate any realize error
> back up to our caller, it would be nicer to do this via
> setting the realize property rather than qdev_init_nofail().
I checked all my patches for new uses of qdev_init_nofail():
* PATCH 02: in realize(), but right next to existing uses. I'm not
making it worse.
* PATCH 03: in helper functions used by board init functions. Okay.
* PATCH 08: in a realize method. Can't actually fail, so let's use
&error_abort.
* PATCH 09 (this one): likewise.
* PATCH 18: in a realize method, and in a realize helper that can't
fail. One of the callers uses qdev_init_nofail() already. Let's Use
&error_abort.
[...]
- Re: [PATCH 04/24] aspeed: Don't create unwanted "ftgmac100", "aspeed-mmi" devices, (continued)
[PATCH 08/24] mac_via: Fix to realize "mos6522-q800-via*" devices, Markus Armbruster, 2020/05/18
[PATCH 12/24] MAINTAINERS: Make section PowerNV cover pci-host/pnv* as well, Markus Armbruster, 2020/05/18
[PATCH 09/24] macio: Fix to realize "mos6522-cuda" and "mos6522-pmu" devices, Markus Armbruster, 2020/05/18
[PATCH 07/24] auxbus: Fix aux-to-i2c-bridge to be a subtype of aux-slave, Markus Armbruster, 2020/05/18
[PATCH 02/24] display/xlnx_dp: Fix to realize "i2c-ddc" and "aux-to-i2c-bridge", Markus Armbruster, 2020/05/18