qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 07/55] qdev: Convert to qdev_unrealize() manually


From: Paolo Bonzini
Subject: Re: [PATCH 07/55] qdev: Convert to qdev_unrealize() manually
Date: Wed, 20 May 2020 08:25:23 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0

On 19/05/20 16:55, Markus Armbruster wrote:
> @@ -493,6 +493,11 @@ bool qdev_realize(DeviceState *dev, BusState *bus, Error 
> **errp)
>      return !err;
>  }
>  
> +void qdev_unrealize(DeviceState *dev)
> +{
> +    object_property_set_bool(OBJECT(dev), false, "realized", &error_abort);
> +}
> +
>  /*
>   * Realize @dev and drop a reference.
>   * This is like qdev_realize(), except it steals a reference rather
> @@ -512,11 +517,6 @@ bool qdev_realize_and_unref(DeviceState *dev, BusState 
> *bus, Error **errp)
>      return ret;
>  }
>  
> -void qdev_unrealize(DeviceState *dev)
> -{
> -    object_property_set_bool(OBJECT(dev), false, "realized", &error_abort);
> -}
> -
>  static int qdev_assert_realized_properly(Object *obj, void *opaque)
>  {
>      DeviceState *dev = DEVICE(object_dynamic_cast(obj, TYPE_DEVICE));

Stray change (to squash in patch 3)?

Paolo




reply via email to

[Prev in Thread] Current Thread [Next in Thread]