[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 07/55] qdev: Convert to qdev_unrealize() manually
From: |
Paolo Bonzini |
Subject: |
Re: [PATCH 07/55] qdev: Convert to qdev_unrealize() manually |
Date: |
Wed, 20 May 2020 08:25:23 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 |
On 19/05/20 16:55, Markus Armbruster wrote:
> @@ -493,6 +493,11 @@ bool qdev_realize(DeviceState *dev, BusState *bus, Error
> **errp)
> return !err;
> }
>
> +void qdev_unrealize(DeviceState *dev)
> +{
> + object_property_set_bool(OBJECT(dev), false, "realized", &error_abort);
> +}
> +
> /*
> * Realize @dev and drop a reference.
> * This is like qdev_realize(), except it steals a reference rather
> @@ -512,11 +517,6 @@ bool qdev_realize_and_unref(DeviceState *dev, BusState
> *bus, Error **errp)
> return ret;
> }
>
> -void qdev_unrealize(DeviceState *dev)
> -{
> - object_property_set_bool(OBJECT(dev), false, "realized", &error_abort);
> -}
> -
> static int qdev_assert_realized_properly(Object *obj, void *opaque)
> {
> DeviceState *dev = DEVICE(object_dynamic_cast(obj, TYPE_DEVICE));
Stray change (to squash in patch 3)?
Paolo
- [PATCH 00/55] qdev: Rework how we plug into the parent bus, Markus Armbruster, 2020/05/19
- [PATCH 04/55] qdev: Put qdev_new() to use with Coccinelle, Markus Armbruster, 2020/05/19
- [PATCH 01/55] qdev: Rename qbus_realize() to qbus_init(), Markus Armbruster, 2020/05/19
- [PATCH 02/55] qdev: Drop redundant bus realization, Markus Armbruster, 2020/05/19
- [PATCH 05/55] qdev: Convert to qbus_realize(), qbus_unrealize(), Markus Armbruster, 2020/05/19
- [PATCH 07/55] qdev: Convert to qdev_unrealize() manually, Markus Armbruster, 2020/05/19
- Re: [PATCH 07/55] qdev: Convert to qdev_unrealize() manually,
Paolo Bonzini <=
- [PATCH 06/55] qdev: Convert to qdev_unrealize() with Coccinelle, Markus Armbruster, 2020/05/19
- [PATCH 13/55] hw/ppc: Eliminate two superfluous QOM casts, Markus Armbruster, 2020/05/19
- [PATCH 19/55] isa: Convert uses of isa_create(), isa_try_create() manually, Markus Armbruster, 2020/05/19
- [PATCH 20/55] isa: isa_create(), isa_try_create() are now unused, drop, Markus Armbruster, 2020/05/19
- [PATCH 09/55] qdev: Convert uses of qdev_create() manually, Markus Armbruster, 2020/05/19
- [PATCH 31/55] auxbus: Convert a use of qdev_set_parent_bus(), Markus Armbruster, 2020/05/19
- [PATCH 23/55] ssi: Convert last use of ssi_create_slave_no_init() manually, Markus Armbruster, 2020/05/19