[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 23/55] ssi: Convert last use of ssi_create_slave_no_init() ma
From: |
Alistair Francis |
Subject: |
Re: [PATCH 23/55] ssi: Convert last use of ssi_create_slave_no_init() manually |
Date: |
Tue, 19 May 2020 13:58:26 -0700 |
On Tue, May 19, 2020 at 8:03 AM Markus Armbruster <address@hidden> wrote:
>
> Same transformation as in the previous commit. Manual, because
> convincing Coccinelle to transform this case is not worthwhile.
>
> Cc: Alistair Francis <address@hidden>
> Signed-off-by: Markus Armbruster <address@hidden>
Looks sane.
Acked-by: Alistair Francis <address@hidden>
Alistair
> ---
> hw/ssi/ssi.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/hw/ssi/ssi.c b/hw/ssi/ssi.c
> index 54106f5ef8..58e7d904db 100644
> --- a/hw/ssi/ssi.c
> +++ b/hw/ssi/ssi.c
> @@ -16,6 +16,7 @@
> #include "hw/ssi/ssi.h"
> #include "migration/vmstate.h"
> #include "qemu/module.h"
> +#include "qapi/error.h"
>
> struct SSIBus {
> BusState parent_obj;
> @@ -96,9 +97,9 @@ DeviceState *ssi_create_slave_no_init(SSIBus *bus, const
> char *name)
>
> DeviceState *ssi_create_slave(SSIBus *bus, const char *name)
> {
> - DeviceState *dev = ssi_create_slave_no_init(bus, name);
> + DeviceState *dev = qdev_new(name);
>
> - qdev_init_nofail(dev);
> + qdev_realize_and_unref(dev, &bus->parent_obj, &error_fatal);
> return dev;
> }
>
> --
> 2.21.1
>
>
- Re: [PATCH 07/55] qdev: Convert to qdev_unrealize() manually, (continued)
- [PATCH 06/55] qdev: Convert to qdev_unrealize() with Coccinelle, Markus Armbruster, 2020/05/19
- [PATCH 13/55] hw/ppc: Eliminate two superfluous QOM casts, Markus Armbruster, 2020/05/19
- [PATCH 19/55] isa: Convert uses of isa_create(), isa_try_create() manually, Markus Armbruster, 2020/05/19
- [PATCH 20/55] isa: isa_create(), isa_try_create() are now unused, drop, Markus Armbruster, 2020/05/19
- [PATCH 09/55] qdev: Convert uses of qdev_create() manually, Markus Armbruster, 2020/05/19
- [PATCH 31/55] auxbus: Convert a use of qdev_set_parent_bus(), Markus Armbruster, 2020/05/19
- [PATCH 23/55] ssi: Convert last use of ssi_create_slave_no_init() manually, Markus Armbruster, 2020/05/19
- Re: [PATCH 23/55] ssi: Convert last use of ssi_create_slave_no_init() manually,
Alistair Francis <=
- [PATCH 30/55] auxbus: New aux_realize_bus(), pairing with aux_init_bus(), Markus Armbruster, 2020/05/19
- [PATCH 11/55] qdev: Convert uses of qdev_set_parent_bus() manually, Markus Armbruster, 2020/05/19
- [PATCH 32/55] auxbus: Eliminate aux_create_slave(), Markus Armbruster, 2020/05/19
- [PATCH 18/55] isa: Convert uses of isa_create() with Coccinelle, Markus Armbruster, 2020/05/19
- [PATCH 33/55] qom: Tidy up a few object_initialize_child() calls, Markus Armbruster, 2020/05/19