[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RISU 0/9] risu cleanups and improvements
|
From: |
Richard Henderson |
|
Subject: |
Re: [RISU 0/9] risu cleanups and improvements |
|
Date: |
Mon, 18 May 2020 12:33:34 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 |
On 5/18/20 11:39 AM, Peter Maydell wrote:
> On Wed, 13 May 2020 at 19:09, Richard Henderson
> <address@hidden> wrote:
>>
>> This patch set does alter the format of the trace files, and thus
>> means we'll have to re-generate these. However, the space saved
>> for sve trace files is significant, so I consider it worthwhile.
>>
>> In addition, the new --dump option allows one to inspect the
>> contents of the trace file.
>
> Alex, would you mind reviewing these risu patches, given that they're
> mostly trace related? (Also you're the one who'll have to regenerate
> a lot of trace files :-))
>
> Richard: if you feed an old trace file to the new risu, what
> error message does it give?
Bah, it should have generated an error vs the magic number, but doesn't -- it
silently exits with success. Alex, expect a v2.
r~
- [RISU 4/9] Adjust tracefile open for write, (continued)
- [RISU 4/9] Adjust tracefile open for write, Richard Henderson, 2020/05/13
- [RISU 8/9] aarch64: Reorg sve reginfo to save space, Richard Henderson, 2020/05/13
- [RISU 7/9] Compute reginfo_size based on the reginfo, Richard Henderson, 2020/05/13
- [RISU 5/9] Use EXIT_FAILURE, EXIT_SUCCESS, Richard Henderson, 2020/05/13
- [RISU 9/9] Add --dump option to inspect trace files, Richard Henderson, 2020/05/13
- Re: [RISU 0/9] risu cleanups and improvements, Peter Maydell, 2020/05/18