Hi
On Mon, May 18, 2020 at 3:37 AM Raphael Norwitz <
address@hidden> wrote:
Hey Marc-Andre,
I'm working on a patchset with changes to libvhost-user. I'm hitting the
following checkpatch error:
Checking 0011-Lift-max-ram-slots-limit-in-libvhost-user.patch...
WARNING: architecture specific defines should be avoided
#117: FILE: contrib/libvhost-user/libvhost-user.h:38:
+#if defined(__i386__) || defined(__x86_64__) || \
total: 0 errors, 1 warnings, 120 lines checked
0011-Lift-max-ram-slots-limit-in-libvhost-user.patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
I'm trying to set the maximum number of ram slots to the max supported by the
target architecture, and I don't know how to check that other than using these
macros. I see other architecture specific macro checks in libvhost-user.h,
such as here:
https://u16159052.ct.sendgrid.net/ls/click?upn=nHC8zHLUbSCl8801JuFxA5IdcFluFbhkOaN0W6nB6sLdfiznj-2FjAzM5FRqjRFWnMRnCWGbBIBOa9D0WJ4d1Dc3pvHvScsomf772bjiFIvKp8WAltnuQtFL02yD-2FAsRP4Fatn_7ODZ15WWDMQmNnbs2AZi2sHUtcz4sYAIHQnA758zSS8fPkeEx38eNnYKLOhQbGVVNhLgwecQ3iL3NTSbIliEXa-2FC6-2BtOz3p1GMC53C8NXjpTFaVfbIGOVMdJbGDgx1DQ1-2B8cWcp7Sf4KOdvdFRXGrnJ4qfS1C1gFLZkiXO2G16QOgNEZ8d4mSR4ELrAtWFNDmtrSLlPlf0u-2F8M2VUHg3zfUhnJ7KytK3PLS1pechDxa-2BYD2SmQyIm-2FHDMY2BGca2
Should I ignore this warning? If not, do you have any other suggestions?
If we need to build libvhost-user per-target, we probably have to change the build-sys - similar to how we build the various qemu targets. This might be tricky, for host & target compatbility.
Can we make it a run-time value instead?
(I am on PTO, I might be a bit slow to reply ;)
--
Marc-André Lureau