qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

checkpatch error checking target arch in libvhost-user


From: Raphael Norwitz
Subject: checkpatch error checking target arch in libvhost-user
Date: Mon, 18 May 2020 01:37:32 +0000 (UTC)

Hey Marc-Andre,

I'm working on a patchset with changes to libvhost-user. I'm hitting the
following checkpatch error:

Checking 0011-Lift-max-ram-slots-limit-in-libvhost-user.patch...
WARNING: architecture specific defines should be avoided
#117: FILE: contrib/libvhost-user/libvhost-user.h:38:
+#if defined(__i386__) || defined(__x86_64__) || \

total: 0 errors, 1 warnings, 120 lines checked

0011-Lift-max-ram-slots-limit-in-libvhost-user.patch has style problems, please 
review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

I'm trying to set the maximum number of ram slots to the max supported by the
target architecture, and I don't know how to check that other than using these
macros. I see other architecture specific macro checks in libvhost-user.h,
such as here:
https://u16159052.ct.sendgrid.net/ls/click?upn=nHC8zHLUbSCl8801JuFxA5IdcFluFbhkOaN0W6nB6sLdfiznj-2FjAzM5FRqjRFWnMRnCWGbBIBOa9D0WJ4d1Dc3pvHvScsomf772bjiFIvKp8WAltnuQtFL02yD-2FAsRP43foG_E8SO-2FEypfU855L0ybQoiQY4Xaj8Z6NYzBoBK89OH-2BiJs2oVXUe9lHVA11uxF6eAFNBHYjrZ2L2x0rg8pxpJb7k58gV-2F0Pcs9b1FHGfiCxHVycMD52nL6rnjHYR0U2e5u-2Bb-2FDyF1ZIH76E5Zwe4Oe1vSdsfafOUWalRu1CMBhlsPO2TcpqiXnBFj1QaM1IrTe5RuhZMjTr5ZROvgb1i-2B74VaAbgKu-2FcfcA8Sk1-2BYxpqTTxs3x6f-2BYkMHAu-2BqEUJdY

Should I ignore this warning? If not, do you have any other suggestions?

Thanks,
Raphael



reply via email to

[Prev in Thread] Current Thread [Next in Thread]