Re: [PULL 00/21] QOM patches for 2020-05-15

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Subject: [PULL 00/21] QOM patches for 2020-05-15
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Switched to a new branch 'test'
5040824 hw: Remove unnecessary DEVICE() cast
d4145a2 various: Remove unnecessary OBJECT() cast
73eddf9 target: Remove unnecessary CPU() cast
e4e3a7a qom: Drop @errp parameter of object_property_del()
3b9532f spapr_pci: Drop some dead error handling
902dde5 qdev: Unrealize must not fail
7029615 Drop more @errp parameters after previous commit
ff79335 qom: Drop parameter @errp of object_property_add() & friends
98fcf7b qdev: Clean up qdev_connect_gpio_out_named()
139eadf hw/arm/bcm2835: Drop futile attempts at QOM-adopting memory
2e82f93 e1000: Don't run e1000_instance_init() twice
4bf355a hw/isa/superio: Make the components QOM children
04710b1 s390x/cpumodel: Fix UI to CPU features pcc-cmac-{aes, eaes}-256
bc6aa87 tests/check-qom-proplist: Improve iterator coverage
61b1706 qom: Drop object_property_set_description() parameter @errp
021ae39 qom: Make all the object_property_add_FOO() return the property
2f09c51 qom: Drop convenience method object_property_get_uint16List()
b0af2a7 qom: Simplify object_property_get_enum()
e4dacbd qom: Drop object_property_del_child()'s unused parameter @errp
2cbfb29 qom: Clean up inconsistent use of gchar * vs. char *
8873048 qom: Clearer reference counting in object_initialize_childv()

=== OUTPUT BEGIN ===
1/21 Checking commit 8873048032f7 (qom: Clearer reference counting in 
object_initialize_childv())
2/21 Checking commit 2cbfb293d78f (qom: Clean up inconsistent use of gchar * 
vs. char *)
3/21 Checking commit e4dacbdb6ab2 (qom: Drop object_property_del_child()'s 
unused parameter @errp)
4/21 Checking commit b0af2a75035c (qom: Simplify object_property_get_enum())
5/21 Checking commit 2f09c51e44b4 (qom: Drop convenience method 
object_property_get_uint16List())
6/21 Checking commit 021ae391e3ef (qom: Make all the object_property_add_FOO() 
return the property)
7/21 Checking commit 61b170673c0f (qom: Drop object_property_set_description() 
parameter @errp)
8/21 Checking commit bc6aa878ff0f (tests/check-qom-proplist: Improve iterator 
coverage)
9/21 Checking commit 04710b18f70e (s390x/cpumodel: Fix UI to CPU features 
pcc-cmac-{aes, eaes}-256)
ERROR: line over 90 characters
#59: FILE: target/s390x/cpu_features_def.inc.h:314:
+DEF_FEAT(PCC_CMAC_AES_256, "pcc-cmac-aes-256", PCC, 20, "PCC 
Compute-Last-Block-CMAC-Using-AES-256")

total: 1 errors, 0 warnings, 8 lines checked

Patch 9/21 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

10/21 Checking commit 4bf355a9cbc7 (hw/isa/superio: Make the components QOM 
children)
11/21 Checking commit 2e82f931795f (e1000: Don't run e1000_instance_init() 
twice)
12/21 Checking commit 139eadf4e599 (hw/arm/bcm2835: Drop futile attempts at 
QOM-adopting memory)
13/21 Checking commit 98fcf7bcfb7d (qdev: Clean up 
qdev_connect_gpio_out_named())
14/21 Checking commit ff79335af770 (qom: Drop parameter @errp of 
object_property_add() & friends)
WARNING: line over 80 characters
#211: FILE: backends/hostmem-file.c:187:
+        file_memory_backend_get_discard_data, 
file_memory_backend_set_discard_data);

WARNING: line over 80 characters
#1082: FILE: hw/arm/raspi.c:287:
+    object_property_add_const_link(OBJECT(&s->soc), "ram", 
OBJECT(machine->ram));

WARNING: line over 80 characters
#3116: FILE: hw/ppc/spapr.c:3336:
+                                   &spapr->kernel_addr, 
OBJ_PROP_FLAG_READWRITE);

total: 0 errors, 3 warnings, 4488 lines checked

Patch 14/21 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
15/21 Checking commit 702961518b09 (Drop more @errp parameters after previous 
commit)
16/21 Checking commit 902dde5776d2 (qdev: Unrealize must not fail)
17/21 Checking commit 3b9532f21d0b (spapr_pci: Drop some dead error handling)
18/21 Checking commit e4e3a7a94712 (qom: Drop @errp parameter of 
object_property_del())
19/21 Checking commit 73eddf9e77ac (target: Remove unnecessary CPU() cast)
20/21 Checking commit d4145a24eef3 (various: Remove unnecessary OBJECT() cast)
21/21 Checking commit 5040824fe472 (hw: Remove unnecessary DEVICE() cast)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden