[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 12/21] hw/arm/bcm2835: Drop futile attempts at QOM-adopting memory
From: |
Markus Armbruster |
Subject: |
[PULL 12/21] hw/arm/bcm2835: Drop futile attempts at QOM-adopting memory |
Date: |
Fri, 15 May 2020 08:04:15 +0200 |
The "bcm2835-peripherals" device's .instance_init() method
bcm2835_peripherals_init() attempts to make two memory regions QOM
children of the device. This is futile, because memory_region_init()
already did. The errors are ignored (a later commit will change
that). Drop the useless calls.
Cc: Peter Maydell <address@hidden>
Cc: Andrew Baumann <address@hidden>
Cc: "Philippe Mathieu-Daudé" <address@hidden>
Cc: address@hidden
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Message-Id: <address@hidden>
---
hw/arm/bcm2835_peripherals.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/hw/arm/bcm2835_peripherals.c b/hw/arm/bcm2835_peripherals.c
index edcaa4916d..8b399d67ff 100644
--- a/hw/arm/bcm2835_peripherals.c
+++ b/hw/arm/bcm2835_peripherals.c
@@ -43,12 +43,10 @@ static void bcm2835_peripherals_init(Object *obj)
/* Memory region for peripheral devices, which we export to our parent */
memory_region_init(&s->peri_mr, obj,"bcm2835-peripherals", 0x1000000);
- object_property_add_child(obj, "peripheral-io", OBJECT(&s->peri_mr), NULL);
sysbus_init_mmio(SYS_BUS_DEVICE(s), &s->peri_mr);
/* Internal memory region for peripheral bus addresses (not exported) */
memory_region_init(&s->gpu_bus_mr, obj, "bcm2835-gpu", (uint64_t)1 << 32);
- object_property_add_child(obj, "gpu-bus", OBJECT(&s->gpu_bus_mr), NULL);
/* Internal memory region for request/response communication with
* mailbox-addressable peripherals (not exported)
--
2.21.1
- [PULL 09/21] s390x/cpumodel: Fix UI to CPU features pcc-cmac-{aes, eaes}-256, (continued)
- [PULL 09/21] s390x/cpumodel: Fix UI to CPU features pcc-cmac-{aes, eaes}-256, Markus Armbruster, 2020/05/15
- [PULL 06/21] qom: Make all the object_property_add_FOO() return the property, Markus Armbruster, 2020/05/15
- [PULL 15/21] Drop more @errp parameters after previous commit, Markus Armbruster, 2020/05/15
- [PULL 19/21] target: Remove unnecessary CPU() cast, Markus Armbruster, 2020/05/15
- [PULL 16/21] qdev: Unrealize must not fail, Markus Armbruster, 2020/05/15
- [PULL 04/21] qom: Simplify object_property_get_enum(), Markus Armbruster, 2020/05/15
- [PULL 11/21] e1000: Don't run e1000_instance_init() twice, Markus Armbruster, 2020/05/15
- [PULL 20/21] various: Remove unnecessary OBJECT() cast, Markus Armbruster, 2020/05/15
- [PULL 21/21] hw: Remove unnecessary DEVICE() cast, Markus Armbruster, 2020/05/15
- [PULL 14/21] qom: Drop parameter @errp of object_property_add() & friends, Markus Armbruster, 2020/05/15
- [PULL 12/21] hw/arm/bcm2835: Drop futile attempts at QOM-adopting memory,
Markus Armbruster <=
- Re: [PULL 00/21] QOM patches for 2020-05-15, no-reply, 2020/05/15
- Re: [PULL 00/21] QOM patches for 2020-05-15, no-reply, 2020/05/15
- Re: [PULL 00/21] QOM patches for 2020-05-15, Peter Maydell, 2020/05/15
- Re: [PULL 00/21] QOM patches for 2020-05-15, no-reply, 2020/05/15