Re: [PATCH v5 2/7] dwc-hsotg (dwc2) USB host controller register definitions

[Philippe Mathieu-Daudé]

On 5/12/20 8:48 AM, Paul Zimmerman wrote:
> Import the dwc-hsotg (dwc2) register definitions file from the
> Linux kernel. This is a copy of drivers/usb/dwc2/hw.h from the
> mainline Linux kernel, the only changes being two instances of
> 'u32' changed to 'uint32_t' to  allow it to compile. Checkpatch
> throws a boatload of errors due to the tab indentation, but I
> would rather import it as-is than reformat it.

Thinking loudly, should this go under linux-headers/?

> Signed-off-by: Paul Zimmerman <address@hidden>
> ---
>   include/hw/usb/dwc2-regs.h | 895 +++++++++++++++++++++++++++++++++++++
>   1 file changed, 895 insertions(+)
>   create mode 100644 include/hw/usb/dwc2-regs.h
>
> diff --git a/include/hw/usb/dwc2-regs.h b/include/hw/usb/dwc2-regs.h
> new file mode 100644
> index 0000000000..96dc07fb6f
> --- /dev/null
> +++ b/include/hw/usb/dwc2-regs.h
> @@ -0,0 +1,895 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause)

Can you use QEMU /* style */ for this single line please?

> +/*
> + * hw.h - DesignWare HS OTG Controller hardware definitions
> + *
> + * Copyright 2004-2013 Synopsys, Inc.

Please add also "imported from Linux kernel file drivers/usb/dwc2/hw.h 
of commit ...".

> + *
> + * Redistribution and use in source and binary forms, with or without
> + * modification, are permitted provided that the following conditions
> + * are met:
> + * 1. Redistributions of source code must retain the above copyright
> + *    notice, this list of conditions, and the following disclaimer,
> + *    without modification.
> + * 2. Redistributions in binary form must reproduce the above copyright
> + *    notice, this list of conditions and the following disclaimer in the
> + *    documentation and/or other materials provided with the distribution.
> + * 3. The names of the above-listed copyright holders may not be used
> + *    to endorse or promote products derived from this software without
> + *    specific prior written permission.
> + *
> + * ALTERNATIVELY, this software may be distributed under the terms of the
> + * GNU General Public License ("GPL") as published by the Free Software
> + * Foundation; either version 2 of the License, or (at your option) any
> + * later version.
> + *
> + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS
> + * IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
> + * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
> + * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR
> + * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
> + * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
> + * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
> + * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF
> + * LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING
> + * NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
> + * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> + */
> +
> +#ifndef __DWC2_HW_H__
> +#define __DWC2_HW_H__
[...]