RE: About migration/colo issue

[Zhanghailiang]

Hi,

I can't reproduce this issue with the qemu upstream either,
It works well.

Did you use an old version ?

Thanks,
Hailiang


> -----Original Message-----
> From: Lukas Straub [mailto:address@hidden]
> Sent: Friday, May 15, 2020 3:12 PM
> To: Zhang, Chen <address@hidden>
> Cc: Zhanghailiang <address@hidden>; Dr . David Alan
> Gilbert <address@hidden>; qemu-devel <address@hidden>; Li
> Zhijian <address@hidden>; Jason Wang <address@hidden>
> Subject: Re: About migration/colo issue
> 
> On Fri, 15 May 2020 03:16:18 +0000
> "Zhang, Chen" <address@hidden> wrote:
> 
> > Hi Hailiang/Dave.
> >
> > I found a urgent problem in current upstream code, COLO will stuck on
> secondary checkpoint and later.
> > The guest will stuck by this issue.
> > I have bisect upstream code, this issue caused by Hailiang's optimize patch:
> 
> Hmm, I'm on v5.0.0 (where that commit is in) and I don't have this issue in
> my testing.
> 
> Regards,
> Lukas Straub
> 
> > From 0393031a16735835a441b6d6e0495a1bd14adb90 Mon Sep 17
> 00:00:00 2001
> > From: zhanghailiang <address@hidden>
> > Date: Mon, 24 Feb 2020 14:54:10 +0800
> > Subject: [PATCH] COLO: Optimize memory back-up process
> >
> > This patch will reduce the downtime of VM for the initial process,
> > Previously, we copied all these memory in preparing stage of COLO
> > while we need to stop VM, which is a time-consuming process.
> > Here we optimize it by a trick, back-up every page while in migration
> > process while COLO is enabled, though it affects the speed of the
> > migration, but it obviously reduce the downtime of back-up all SVM'S
> > memory in COLO preparing stage.
> >
> > Signed-off-by: zhanghailiang <address@hidden>
> > Message-Id:
> <address@hidden>
> > Signed-off-by: Dr. David Alan Gilbert <address@hidden>
> >   minor typo fixes
> >
> > Hailiang, do you have time to look into it?
> >
> > ...