[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 02/16] target/arm: Create gen_gvec_{u,s}{rshr,rsra}
|
From: |
Richard Henderson |
|
Subject: |
Re: [PATCH v3 02/16] target/arm: Create gen_gvec_{u,s}{rshr,rsra} |
|
Date: |
Tue, 12 May 2020 19:06:33 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 |
On 5/12/20 6:51 AM, Peter Maydell wrote:
>> + tcg_gen_gvec_dup_imm(vece, rd_ofs, opr_sz, max_sz, 0);
>
> Knew I'd forgotten a review comment -- should this "dup_imm to clear
> to zeroes" be using a fixed element size rather than 'vece' to avoid
> the "dup_imm doesn't handle 128 bits" issue? (Similarly elsewhere.)
No, because here we cannot have 128-bit elements (not 128-bit vectors).
r~
- [PATCH v3 00/16] target/arm: partial vector cleanup, Richard Henderson, 2020/05/08
- [PATCH v3 01/16] target/arm: Create gen_gvec_[us]sra, Richard Henderson, 2020/05/08
- [PATCH v3 02/16] target/arm: Create gen_gvec_{u,s}{rshr,rsra}, Richard Henderson, 2020/05/08
- Re: [PATCH v3 02/16] target/arm: Create gen_gvec_{u,s}{rshr,rsra}, Peter Maydell, 2020/05/12
- Re: [PATCH v3 02/16] target/arm: Create gen_gvec_{u,s}{rshr,rsra},
Richard Henderson <=
- [PATCH v3 03/16] target/arm: Create gen_gvec_{sri,sli}, Richard Henderson, 2020/05/08
- [PATCH v3 04/16] target/arm: Remove unnecessary range check for VSHL, Richard Henderson, 2020/05/08
- [PATCH v3 05/16] target/arm: Tidy handle_vec_simd_shri, Richard Henderson, 2020/05/08
- [PATCH v3 08/16] target/arm: Swap argument order for VSHL during decode, Richard Henderson, 2020/05/08
- [PATCH v3 07/16] target/arm: Create gen_gvec_{mla,mls}, Richard Henderson, 2020/05/08