Re: [PATCH v4 00/18] target/arm: sve load/store improvements

[Richard Henderson]

On 5/5/20 2:49 AM, Peter Maydell wrote:
> On Mon, 4 May 2020 at 17:03, Richard Henderson
> <address@hidden> wrote:
>>
>> On 5/4/20 2:43 AM, Peter Maydell wrote:
>>> I've reviewed patch 13, but I still don't understand why you've
>>> made the size-related changes in patch 4, so I've continued
>>> our conversation in the thread on the v3 version of that patch.
>>
>> I've changed that here in v4.  Please have another look at this one.
> 
> The page_check_range() call still seems to be passing a fixed
> size of '1' ?

We only need to validate one page, so validating one byte on the page is
sufficient.  The size argument to page_check_range is so that it can validate
multiple pages at a time.

The target exception is raised by cc->tlb_fill, and there we pass either the
actual access size (probe_access) or 0 to indicate unknown access size
(probe_access_flags, or probe_access passed down from the caller).


r~