Re: [PATCH v4 00/18] target/arm: sve load/store improvements

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Subject: [PATCH v4 00/18] target/arm: sve load/store improvements
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
82ee270 target/arm: Remove sve_memopidx
fab9c40 target/arm: Reuse sve_probe_page for gather loads
f70bb77 target/arm: Reuse sve_probe_page for scatter stores
4e596dc target/arm: Reuse sve_probe_page for gather first-fault loads
468a67f target/arm: Use SVEContLdSt for contiguous stores
9a0478c target/arm: Update contiguous first-fault and no-fault loads
918f6f4 target/arm: Use SVEContLdSt for multi-register contiguous loads
d9511b0 target/arm: Handle watchpoints in sve_ld1_r
c79af96 target/arm: Use SVEContLdSt in sve_ld1_r
e6c154a target/arm: Adjust interface of sve_ld1_host_fn
b4217ec target/arm: Add sve infrastructure for page lookup
3469d99 target/arm: Drop manual handling of set/clear_helper_retaddr
5910347 target/arm: Use cpu_*_data_ra for sve_ldst_tlb_fn
a0d4423 accel/tcg: Add endian-specific cpu_{ld, st}* operations
0b84297 accel/tcg: Add probe_access_flags
ac7b3fb accel/tcg: Add block comment for probe_access
00a9ec0 exec: Fix cpu_watchpoint_address_matches address length
10cd650 exec: Add block comments for watchpoint routines

=== OUTPUT BEGIN ===
1/18 Checking commit 10cd6507e74a (exec: Add block comments for watchpoint 
routines)
2/18 Checking commit 00a9ec0026c5 (exec: Fix cpu_watchpoint_address_matches 
address length)
3/18 Checking commit ac7b3fbdeb61 (accel/tcg: Add block comment for 
probe_access)
4/18 Checking commit 0b842976537b (accel/tcg: Add probe_access_flags)
5/18 Checking commit a0d4423f54d3 (accel/tcg: Add endian-specific cpu_{ld, st}* 
operations)
6/18 Checking commit 59103472222f (target/arm: Use cpu_*_data_ra for 
sve_ldst_tlb_fn)
ERROR: spaces required around that '*' (ctx:VxV)
#63: FILE: target/arm/sve_helper.c:4029:
+    TLB(env, addr, (TYPEM)*(TYPEE *)(vd + H(reg_off)), ra);                 \
                           ^

ERROR: spaces required around that '*' (ctx:WxV)
#153: FILE: target/arm/sve_helper.c:4162:
+                      sve_ldst1_tlb_fn *tlb_fn)
                                        ^

total: 2 errors, 0 warnings, 455 lines checked

Patch 6/18 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

7/18 Checking commit 3469d99d0d94 (target/arm: Drop manual handling of 
set/clear_helper_retaddr)
8/18 Checking commit b4217ec4779a (target/arm: Add sve infrastructure for page 
lookup)
WARNING: Block comments use a leading /* on a separate line
#32: FILE: target/arm/sve_helper.c:1633:
+/* Big-endian hosts need to frob the byte indices.  If the copy

total: 0 errors, 1 warnings, 281 lines checked

Patch 8/18 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
9/18 Checking commit e6c154a82e83 (target/arm: Adjust interface of 
sve_ld1_host_fn)
10/18 Checking commit c79af9613ec5 (target/arm: Use SVEContLdSt in sve_ld1_r)
11/18 Checking commit d9511b04ab6a (target/arm: Handle watchpoints in sve_ld1_r)
12/18 Checking commit 918f6f478a6f (target/arm: Use SVEContLdSt for 
multi-register contiguous loads)
13/18 Checking commit 9a0478c3a5e6 (target/arm: Update contiguous first-fault 
and no-fault loads)
14/18 Checking commit 468a67f2b0ff (target/arm: Use SVEContLdSt for contiguous 
stores)
15/18 Checking commit 4e596dc2ae1a (target/arm: Reuse sve_probe_page for gather 
first-fault loads)
16/18 Checking commit f70bb771ff66 (target/arm: Reuse sve_probe_page for 
scatter stores)
17/18 Checking commit fab9c404e5d8 (target/arm: Reuse sve_probe_page for gather 
loads)
18/18 Checking commit 82ee27018cd7 (target/arm: Remove sve_memopidx)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden