Re: [PATCH v4 0/7] ARM virt: Add NVDIMM support

[Peter Maydell]

On Mon, 4 May 2020 at 10:46, Michael S. Tsirkin <address@hidden> wrote:
>
> On Mon, May 04, 2020 at 10:29:18AM +0100, Peter Maydell wrote:
> > I notice that checkpatch complains a lot about
> >
> > ERROR: Do not add expected files together with tests, follow
> > instructions in tests/qtest/bios-tables-test.c: both
> > tests/qtest/bios-tables-test-allowed-diff.h and
> > tests/qtest/bios-tables-test.c found
> >
> > Does that need fixing, or is the checkpatch test wrong?

> Hmm I don't see a patch in this series that changes both
> tests/qtest/bios-tables-test-allowed-diff.h and
> tests/qtest/bios-tables-test.c. Do you?

No, but that's not the pair of files that checkpatch is
complaining about. It warns about:

patch 1:
 tests/qtest/bios-tables-test-allowed-diff.h and hw/acpi/nvdimm.c

patch 2:
 tests/qtest/bios-tables-test-allowed-diff.h and hw/acpi/nvdimm.c
 tests/qtest/bios-tables-test-allowed-diff.h and hw/i386/acpi-build.c
 tests/qtest/bios-tables-test-allowed-diff.h and hw/i386/acpi-build.h
 tests/qtest/bios-tables-test-allowed-diff.h and hw/i386/pc_piix.c
 tests/qtest/bios-tables-test-allowed-diff.h and hw/i386/pc_q35.c
 tests/qtest/bios-tables-test-allowed-diff.h and include/hw/mem/nvdimm.h

patch 3:
 tests/qtest/bios-tables-test-allowed-diff.h and hw/arm/Kconfig
 tests/qtest/bios-tables-test-allowed-diff.h and hw/arm/virt-acpi-build.c
 tests/qtest/bios-tables-test-allowed-diff.h and hw/arm/virt.c
 tests/qtest/bios-tables-test-allowed-diff.h and hw/mem/Kconfig
 tests/qtest/bios-tables-test-allowed-diff.h and include/hw/arm/virt.h

etc, and the patches really do touch the pairs of files listed.
(It also seems to warn about each file combination multiple times.)

Are these false positives (if so, we should change the checkpatch test,
since it's clearly misfiring a lot) or problems with the patches?

thanks
-- PMM