Re: [PATCH v4 0/7] ARM virt: Add NVDIMM support

[Peter Maydell]

On Mon, 4 May 2020 at 06:13, Michael S. Tsirkin <address@hidden> wrote:
>
> On Tue, Apr 21, 2020 at 01:59:27PM +0100, Shameer Kolothum wrote:
> > This series adds NVDIMM support to arm/virt platform.
> > The series reuses some of the patches posted by Eric
> > in his earlier attempt here[1].
> >
> > This series previously had few fixes to qemu in general
> > which were discovered while adding nvdimm support to arm/virt.
> > Those were sent out seperately[2] and are now part of Qemu.
>
>
> Mostly ACPI stuff so I can merge it if I get an ack for ARM side.

Happy for you to take it; all the arm-specific bits have
been reviewed by various people (thanks!) so here's my

Acked-by: Peter Maydell <address@hidden>

I notice that checkpatch complains a lot about

ERROR: Do not add expected files together with tests, follow
instructions in tests/qtest/bios-tables-test.c: both
tests/qtest/bios-tables-test-allowed-diff.h and
tests/qtest/bios-tables-test.c found

Does that need fixing, or is the checkpatch test wrong?

thanks
-- PMM