Re: [PATCH v5 1/8] multifd: Add multifd-method parameter

[Markus Armbruster]

Juan Quintela <address@hidden> writes:

> Markus Armbruster <address@hidden> wrote:
>> Juan Quintela <address@hidden> writes:
>>
>>> This will store the compression method to use.  We start with none.
>>>
>>> Signed-off-by: Juan Quintela <address@hidden>
>>> Reviewed-by: Markus Armbruster <address@hidden>
>>
>> I don't remember giving my R-by.  I gave my Acked-by for
>> [PATCH v2 06/10] migration: Add multifd-compress parameter
>> Message-ID: <address@hidden>
>> https://lists.nongnu.org/archive/html/qemu-devel/2019-12/msg04153.html
>
>> If I did give my R-by for a later revision, let me know.
>
> Hi
>
> Ouch, I *thought* that you got confused.  It happens to me all the time.
> Apologies.
> So, how I should I put that Acked-by: in the commit?

Replace

    Reviewed-by: Markus Armbruster <address@hidden>

by

    Acked-by: Markus Armbruster <address@hidden>

>> One small suggestion below.
>
> Thanks.
>
>>> Reviewed-by: Dr. David Alan Gilbert <address@hidden>
>> [...]
>>> diff --git a/qapi/migration.json b/qapi/migration.json
>>> index b7348d0c8b..96a126751c 100644
>>> --- a/qapi/migration.json
>>> +++ b/qapi/migration.json
>>> @@ -488,6 +488,19 @@
>>>  ##
>>>  { 'command': 'query-migrate-capabilities', 'returns':
>>> ['MigrationCapabilityStatus']}
>>>  
>>> +##
>>> +# @MultiFDMethod:
>>> +#
>>> +# An enumeration of multifd compression.
>>
>> Suggest "compression methods."
>
> will do.
>
> Sorry again for the missunderstanding.

No harm, no foul :)