qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v5 4/8] multifd: Add multifd-zlib-level parameter


From: Markus Armbruster
Subject: Re: [PATCH v5 4/8] multifd: Add multifd-zlib-level parameter
Date: Thu, 30 Jan 2020 09:03:00 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)

Juan Quintela <address@hidden> writes:

> It will indicate which level use for compression.
>
> Signed-off-by: Juan Quintela <address@hidden>

This is slightly confusing (there is no zlib compression), unless you
peek at the next patch (which adds zlib compression).

Three ways to make it less confusing:

* Squash the two commits

* Swap them: first add zlib compression with level hardcoded to 1, then
  make the level configurable.

* Have the first commit explain itself better.  Something like

    multifd: Add multifd-zlib-level parameter

    This parameter specifies zlib compression level.  The next patch
    will put it to use.

For QAPI:
Acked-by: Markus Armbruster <address@hidden>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]