[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 001/142] minikconf: accept alnum identifiers
|
From: |
Thomas Huth |
|
Subject: |
Re: [PATCH 001/142] minikconf: accept alnum identifiers |
|
Date: |
Wed, 29 Jan 2020 14:47:01 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 |
On 29/01/2020 14.41, Marc-André Lureau wrote:
> Hi
>
> On Wed, Jan 29, 2020 at 1:09 PM Thomas Huth <address@hidden> wrote:
>>
>>
>> -EMISSINGPATCHDESCRIPTION
>>
>> Why is this required? Bug fix? New feature? ... please add some words here.
>
> This is required for later patch "meson: convert hw/9pfs", which adds
> config 9PFS.
>
> You are right, several patches could use some comments. It's still
> PoC. Otoh, a lot of them are quite mechanical or just what they are in
> meson, there isn't much to say about it. We'll have to improve this
> somehow.
Sure, but with a proper patch description, this patch here could even be
merged today already, shrinking this huge patch series by one at least...
Thomas
[PATCH 005/142] configure: do not include $(...) variables in config-host.mak, Paolo Bonzini, 2020/01/28
[PATCH 006/142] configure: expand path variables for meson configure, Paolo Bonzini, 2020/01/28
[PATCH 008/142] configure: generate Meson cross file, Paolo Bonzini, 2020/01/28
[PATCH 010/142] meson: enable pie, Paolo Bonzini, 2020/01/28
[PATCH 009/142] build-sys: add meson submodule, Paolo Bonzini, 2020/01/28
[PATCH 007/142] configure: integrate Meson in the build system, Paolo Bonzini, 2020/01/28
[PATCH 011/142] meson: use coverage option, Paolo Bonzini, 2020/01/28
[PATCH 012/142] meson: add testsuite Makefile generator, Paolo Bonzini, 2020/01/28