Re: [PATCH 001/142] minikconf: accept alnum identifiers

[Marc-André Lureau]

Hi

On Wed, Jan 29, 2020 at 1:09 PM Thomas Huth <address@hidden> wrote:
>
>
> -EMISSINGPATCHDESCRIPTION
>
> Why is this required? Bug fix? New feature? ... please add some words here.

This is required for later patch "meson: convert hw/9pfs", which adds
config 9PFS.

You are right, several patches could use some comments. It's still
PoC. Otoh, a lot of them are quite mechanical or just what they are in
meson, there isn't much to say about it. We'll have to improve this
somehow.

>  Thomas
>
>
> On 28/01/2020 18.51, Paolo Bonzini wrote:
> > From: Marc-André Lureau <address@hidden>
> >
> > Signed-off-by: Marc-André Lureau <address@hidden>
> > Signed-off-by: Paolo Bonzini <address@hidden>
> > ---
> >  scripts/minikconf.py | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/scripts/minikconf.py b/scripts/minikconf.py
> > index 40ae1989e1..febd9a479f 100644
> > --- a/scripts/minikconf.py
> > +++ b/scripts/minikconf.py
> > @@ -645,7 +645,7 @@ class KconfigParser:
> >              self.cursor = self.src.find('\n', self.cursor)
> >              self.val = self.src[start:self.cursor]
> >              return TOK_SOURCE
> > -        elif self.tok.isalpha():
> > +        elif self.tok.isalnum():
> >              # identifier
> >              while self.src[self.cursor].isalnum() or self.src[self.cursor] 
> > == '_':
> >                  self.cursor += 1
> >
>