[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 00/13] RFC: [for 5.0]: HMP monitor handlers cleanups
|
From: |
Ján Tomko |
|
Subject: |
Re: [PATCH v3 00/13] RFC: [for 5.0]: HMP monitor handlers cleanups |
|
Date: |
Tue, 28 Jan 2020 10:13:32 +0100 |
On Mon, Jan 27, 2020 at 04:01:31PM -0500, John Snow wrote:
On 1/27/20 3:43 PM, Peter Krempa wrote:
On Mon, Jan 27, 2020 at 14:39:02 -0500, John Snow wrote:
On 1/27/20 5:36 AM, Maxim Levitsky wrote:
This patch series is bunch of cleanups
to the hmp monitor code.
This series only touched blockdev related hmp handlers.
No functional changes expected other that
light error message changes by the last patch.
This was inspired by this bugzilla:
https://bugzilla.redhat.com/show_bug.cgi?id=1719169
Basically some users still parse hmp error messages,
and they would like to have them prefixed with 'Error:'
[...]
The bug was reported at the time when libvirt didn't use blockdev yet,
but at this point it's pointless from our side.
Just for the record, this bug was the motivation for the prefix request:
https://bugzilla.redhat.com/show_bug.cgi?id=1718255
This wouldn't even fix
the scenario when old (pre-5.10) libvirt would use new qemu because the
drive-add handler never checked the error prefix.
And running older libvirt with newer QEMU is not something we care
about.
Jano
[1]
https://libvirt.org/git/?p=libvirt.git;a=blob;f=src/qemu/qemu_monitor_text.c;h=9135a11f0a3aae718c86bb199112fba8d16d4d80;hb=HEAD
Thank you for the report from libvirtville :)
--js
signature.asc
Description: PGP signature
- [PATCH v3 09/13] monitor/hmp: move remaining hmp_block* functions to block-hmp-cmds.c, (continued)
- [PATCH v3 09/13] monitor/hmp: move remaining hmp_block* functions to block-hmp-cmds.c, Maxim Levitsky, 2020/01/27
- [PATCH v3 11/13] monitor: Move hmp_drive_add_node to block-hmp-cmds.c, Maxim Levitsky, 2020/01/27
- [PATCH v3 10/13] monitor/hmp: move hmp_info_block* to block-hmp-cmds.c, Maxim Levitsky, 2020/01/27
- [PATCH v3 13/13] monitor/hmp: Prefer to use hmp_handle_error for error reporting in block hmp commands, Maxim Levitsky, 2020/01/27
- [PATCH v3 12/13] add 'error' prefix to vreport, Maxim Levitsky, 2020/01/27
- Re: [PATCH v3 00/13] RFC: [for 5.0]: HMP monitor handlers cleanups, no-reply, 2020/01/27
- Re: [PATCH v3 00/13] RFC: [for 5.0]: HMP monitor handlers cleanups, John Snow, 2020/01/27