[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 00/13] RFC: [for 5.0]: HMP monitor handlers cleanups
From: |
John Snow |
Subject: |
Re: [PATCH v3 00/13] RFC: [for 5.0]: HMP monitor handlers cleanups |
Date: |
Mon, 27 Jan 2020 14:39:02 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.0 |
On 1/27/20 5:36 AM, Maxim Levitsky wrote:
> This patch series is bunch of cleanups
> to the hmp monitor code.
>
> This series only touched blockdev related hmp handlers.
>
> No functional changes expected other that
> light error message changes by the last patch.
>
> This was inspired by this bugzilla:
> https://bugzilla.redhat.com/show_bug.cgi?id=1719169
>
> Basically some users still parse hmp error messages,
> and they would like to have them prefixed with 'Error:'
>
HMP isn't meant to be parsed. It's explicitly *not* API or ABI. I do
like consistency in my UIs (it's useful for human eyes, too), but I'd
like to know more about the request.
Is this request coming from libvirt? Can we wean them off of this
interface? What do they need as a replacement?
(Is blockdev not enough?)
--js
- [PATCH v3 07/13] monitor/hmp: move hmp_snapshot_* to block-hmp-cmds.c, (continued)
- [PATCH v3 07/13] monitor/hmp: move hmp_snapshot_* to block-hmp-cmds.c, Maxim Levitsky, 2020/01/27
- [PATCH v3 06/13] monitor/hmp: move hmp_block_job* to block-hmp-cmds.c, Maxim Levitsky, 2020/01/27
- [PATCH v3 08/13] monitor/hmp: move hmp_nbd_server* to block-hmp-cmds.c, Maxim Levitsky, 2020/01/27
- [PATCH v3 09/13] monitor/hmp: move remaining hmp_block* functions to block-hmp-cmds.c, Maxim Levitsky, 2020/01/27
- [PATCH v3 11/13] monitor: Move hmp_drive_add_node to block-hmp-cmds.c, Maxim Levitsky, 2020/01/27
- [PATCH v3 10/13] monitor/hmp: move hmp_info_block* to block-hmp-cmds.c, Maxim Levitsky, 2020/01/27
- [PATCH v3 13/13] monitor/hmp: Prefer to use hmp_handle_error for error reporting in block hmp commands, Maxim Levitsky, 2020/01/27
- [PATCH v3 12/13] add 'error' prefix to vreport, Maxim Levitsky, 2020/01/27
- Re: [PATCH v3 00/13] RFC: [for 5.0]: HMP monitor handlers cleanups, no-reply, 2020/01/27
- Re: [PATCH v3 00/13] RFC: [for 5.0]: HMP monitor handlers cleanups,
John Snow <=