Re: [PATCH v4 6/7] disas: mips: Add micromips R6 disassembler - infrastructure and 16-bit instructions

[Richard Henderson]

On 1/24/20 10:56 AM, Aleksandar Markovic wrote:
> 
> 
> On Friday, January 24, 2020, Richard Henderson <address@hidden
> <mailto:address@hidden>> wrote:
> 
>     On 1/24/20 6:38 AM, Aleksandar Markovic wrote:
>     > The basic disassembly logic was obtained by somewhat modified script
>     > decodetree.py, and such output was further manually modified to
>     > handle numerous details of micromips 32R6 instruction coding scheme.
> 
>     What modifications to the script?
>     What manual modifications to the output?
> 
>     It's been a while since I looked at micromips, but I don't recall 
> anything so
>     odd that it couldn't be handled with the current output of decodetree.py.
> 
> 
> I don't have dev setup at hand right now, but I can look it up in few days.
> Some of the changes are purely of cosmetic nature (like outputing binary
> instead of hex codes), but some are not. I can send you the whole modified
> script, once I come back to my desk. There are some not-so-obvious micromips
> oddities, if one delves enough into the coding scheme.

The thing I'm concerned about here is any future maintenance of this file.  One
would surely prefer to edit the original decodetree input than this output.


r~