Re: [PATCH v4 0/7] target/mips: Misc MIPS fixes and improvements for 5.0

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [PATCH v4 0/7] target/mips: Misc MIPS fixes and improvements for 5.0

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Switched to a new branch 'test'
ea518ca disas: mips: Add micromips R6 disassembler - 32-bit instructions
411fb98 disas: mips: Add micromips R6 disassembler - infrastructure and 16-bit 
instructions
21156b5 disas: Add a field for target-dependant data
e1f78b4 target/mips: Add implementation of GINVT instruction
71cda0b target/mips: Amend CP0 WatchHi register implementation
4ba5d5b target/mips: Add support for MIPS<32|64>R6 CRC32 ISA
1a1d967 target/mips: Rectify documentation on deprecating r4k machine

=== OUTPUT BEGIN ===
1/7 Checking commit 1a1d96728818 (target/mips: Rectify documentation on 
deprecating r4k machine)
2/7 Checking commit 4ba5d5ba89b6 (target/mips: Add support for MIPS<32|64>R6 
CRC32 ISA)
3/7 Checking commit 71cda0b1edd7 (target/mips: Amend CP0 WatchHi register 
implementation)
4/7 Checking commit e1f78b41860b (target/mips: Add implementation of GINVT 
instruction)
5/7 Checking commit 21156b50dd72 (disas: Add a field for target-dependant data)
6/7 Checking commit 411fb9817917 (disas: mips: Add micromips R6 disassembler - 
infrastructure and 16-bit instructions)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#36: 
new file mode 100644

ERROR: space prohibited between function name and open parenthesis '('
#1297: FILE: include/disas/dis-asm.h:395:
+int print_insn_micromips_r6      (bfd_vma, disassemble_info*);

total: 1 errors, 1 warnings, 1272 lines checked

Patch 6/7 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

7/7 Checking commit ea518ca26f0d (disas: mips: Add micromips R6 disassembler - 
32-bit instructions)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden