Re: [PULL v2 00/59] Misc (x86 and QOM) patches for 2020-01-23

[Paolo Bonzini]

On 24/01/20 00:31, Richard Henderson wrote:
> On 1/23/20 9:20 AM, Paolo Bonzini wrote:
>> Il gio 23 gen 2020, 19:43 Peter Maydell <address@hidden
>> <mailto:address@hidden>> ha scritto:
>>     When I try to build-test this merge, the clang sanitizer
>>     build seems to fail whenever it tries to link anything:
>>     (configure args '--cc=clang' '--cxx=clang++' '--enable-gtk'
>>     '--extra-cflags=-fsanitize=undefined  -fno-sanitize=shift-base -Werror')
>>
>>
>> That's intended, you need to add -fsanitize=undefined to --extra-ldflags as
>> well now. I can change that back, but then I am not sure what one would use
>> --extra-ldflags for.
> 
> This seems broken to me.  Most cflags have to be present on the link line as
> well, unless you know very much what you're doing.  I would not expect
> --extra-cflags to have to be repeated.

But then Peter's command line is missing --extra-cxxflags.  So I think
more clarity is better even at the cost of verbosity.  Anyway, for now
I'll make --extra-cflags affect both EXTRA_CFLAGS and EXTRA_LDFLAGS.

Paolo