[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 03/20] tests/tcg/aarch64: Fix compilation parameters for pauth-%
From: |
Peter Maydell |
Subject: |
[PULL 03/20] tests/tcg/aarch64: Fix compilation parameters for pauth-% |
Date: |
Thu, 23 Jan 2020 15:30:24 +0000 |
From: Richard Henderson <address@hidden>
We were incorrectly requiring ARMv8.4 support for the pauth
tests, but Pointer Authentication is an ARMv8.3 extension.
Further, hiding the required architecture within asm() is
not correct.
Correct the architecture version requested, and specify it
in the cflags of the (cross-) compiler rather than in the asm.
Signed-off-by: Richard Henderson <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Message-id: address@hidden
[PMM: tweaked commit message]
Signed-off-by: Peter Maydell <address@hidden>
---
tests/tcg/aarch64/Makefile.target | 1 +
tests/tcg/aarch64/pauth-1.c | 2 --
tests/tcg/aarch64/pauth-2.c | 2 --
3 files changed, 1 insertion(+), 4 deletions(-)
diff --git a/tests/tcg/aarch64/Makefile.target
b/tests/tcg/aarch64/Makefile.target
index df3fe8032c3..374c8d6830f 100644
--- a/tests/tcg/aarch64/Makefile.target
+++ b/tests/tcg/aarch64/Makefile.target
@@ -20,6 +20,7 @@ run-fcvt: fcvt
# Pauth Tests
AARCH64_TESTS += pauth-1 pauth-2
run-pauth-%: QEMU_OPTS += -cpu max
+pauth-%: CFLAGS += -march=armv8.3-a
# Semihosting smoke test for linux-user
AARCH64_TESTS += semihosting
diff --git a/tests/tcg/aarch64/pauth-1.c b/tests/tcg/aarch64/pauth-1.c
index a3c1443cd07..ea0984ea823 100644
--- a/tests/tcg/aarch64/pauth-1.c
+++ b/tests/tcg/aarch64/pauth-1.c
@@ -2,8 +2,6 @@
#include <sys/prctl.h>
#include <stdio.h>
-asm(".arch armv8.4-a");
-
#ifndef PR_PAC_RESET_KEYS
#define PR_PAC_RESET_KEYS 54
#define PR_PAC_APDAKEY (1 << 2)
diff --git a/tests/tcg/aarch64/pauth-2.c b/tests/tcg/aarch64/pauth-2.c
index 2fe030ba3da..9bba0beb639 100644
--- a/tests/tcg/aarch64/pauth-2.c
+++ b/tests/tcg/aarch64/pauth-2.c
@@ -1,8 +1,6 @@
#include <stdint.h>
#include <assert.h>
-asm(".arch armv8.4-a");
-
void do_test(uint64_t value)
{
uint64_t salt1, salt2;
--
2.20.1
- [PULL 00/20] target-arm queue, Peter Maydell, 2020/01/23
- [PULL 01/20] target/arm: add PMU feature to cortex-r5 and cortex-r5f, Peter Maydell, 2020/01/23
- [PULL 04/20] tests/tcg/aarch64: Add pauth-3, Peter Maydell, 2020/01/23
- [PULL 05/20] tests/tcg/aarch64: Add pauth-4, Peter Maydell, 2020/01/23
- [PULL 07/20] hw/arm: Use helper function to trigger hotplug handler plug, Peter Maydell, 2020/01/23
- [PULL 03/20] tests/tcg/aarch64: Fix compilation parameters for pauth-%,
Peter Maydell <=
- [PULL 06/20] hw/acpi: Remove extra indent in ACPI GED hotplug cb, Peter Maydell, 2020/01/23
- [PULL 02/20] target/arm: Fix PAuth sbox functions, Peter Maydell, 2020/01/23
- [PULL 09/20] docs: Create stub system manual, Peter Maydell, 2020/01/23
- [PULL 08/20] qemu-nbd: Convert invocation documentation to rST, Peter Maydell, 2020/01/23
- [PULL 12/20] hw/misc/stm32f4xx_syscfg: Fix copy/paste error, Peter Maydell, 2020/01/23
- [PULL 14/20] hw/core/or-irq: Increase limit of or-lines to 48, Peter Maydell, 2020/01/23
- [PULL 13/20] dma/pl330: Convert to support tracing, Peter Maydell, 2020/01/23
- [PULL 15/20] hw/arm/exynos4210: Fix DMA initialization, Peter Maydell, 2020/01/23
- [PULL 11/20] target/arm/arch_dump: Add SVE notes, Peter Maydell, 2020/01/23
- [PULL 17/20] hw/char/exynos4210_uart: Implement post_load function, Peter Maydell, 2020/01/23