[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] qapi: Fix code generation with Python 3.5
|
From: |
Peter Maydell |
|
Subject: |
Re: [PATCH] qapi: Fix code generation with Python 3.5 |
|
Date: |
Mon, 20 Jan 2020 12:53:28 +0000 |
On Thu, 16 Jan 2020 at 20:27, Markus Armbruster <address@hidden> wrote:
>
> Recent commit 3e7fb5811b "qapi: Fix code generation for empty modules"
> modules" switched QAPISchema.visit() from
>
> for entity in self._entity_list:
>
> effectively to
>
> for mod in self._module_dict.values():
> for entity in mod._entity_list:
>
> Visits in the same order as long as .values() is in insertion order.
> That's the case only for Python 3.6 and later. Before, it's in some
> arbitrary order, which results in broken generated code.
>
> Fix by making self._module_dict an OrderedDict rather than a dict.
>
> Fixes: 3e7fb5811baab213dcc7149c3aa69442d683c26c
> Signed-off-by: Markus Armbruster <address@hidden>
> --
Applied to master as a buildfix, thanks.
-- PMM
- Re: [PATCH] qapi: Fix code generation with Python 3.5, (continued)
Re: [PATCH] qapi: Fix code generation with Python 3.5, Thomas Huth, 2020/01/17
Re: [PATCH] qapi: Fix code generation with Python 3.5, Alex Bennée, 2020/01/20
Re: [PATCH] qapi: Fix code generation with Python 3.5,
Peter Maydell <=